feat(optimizer)!: annotate types for Snowflake TRIM function #5811
+92
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-BradfordPaskewitz
requested review from
georgesittas and
fivetran-amrutabhimsenayachit
fivetran-BradfordPaskewitz
force-pushed
the
brad/snowflake_trim
branch
from
adbf956 to
5523db4
Compare
geooo109
reviewed
Sep 6, 2025
fivetran-BradfordPaskewitz
force-pushed
the
brad/snowflake_trim
branch
from
5523db4 to
4d50998
Compare
fivetran-BradfordPaskewitz
changed the title
fivetran-BradfordPaskewitz
force-pushed
the
brad/snowflake_trim
branch
from
4d50998 to
5c9f5d0
Compare
fivetran-BradfordPaskewitz
force-pushed
the
brad/snowflake_trim
branch
from
5c9f5d0 to
668fd8b
Compare
geooo109
approved these changes
Sep 10, 2025
fivetran-BradfordPaskewitz
force-pushed
the
brad/snowflake_trim
branch
from
668fd8b to
4f7e4c3
Compare
fivetran-BradfordPaskewitz
force-pushed
the
brad/snowflake_trim
branch
from
4f7e4c3 to
3b4e463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for Snowflake TRIM function
documentation: https://docs.snowflake.com/en/sql-reference/functions/trim