Skip to content

fix(core): Ensure getNodeOutputs always returns an array #19069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 2, 2025
Merged

fix(core): Ensure getNodeOutputs always returns an array #19069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
adf31d3
fix(core): Ensure getNodeOutputs always returns an array
cstuncsik Sep 1, 2025
f7c2a00
fix(core): Ensure outputs are correctly typed as NodeConnectionType o…
cstuncsik Sep 1, 2025
f0d837b
fix(core): Add type guard to validate outputs array in getNodeOutputs…
cstuncsik Sep 2, 2025
78e1d8f
fix(core): Simplify outputs validation in getNodeOutputs function
cstuncsik Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/workflow/src/node-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,12 +1047,15 @@ export function getNodeOutputs(
} else {
// Calculate the outputs dynamically
try {
outputs = (workflow.expression.getSimpleParameterValue(
const result = workflow.expression.getSimpleParameterValue(
node,
nodeTypeData.outputs,
'internal',
{},
) || []) as NodeConnectionType[];
);
outputs = Array.isArray(result)
? (result as Array<NodeConnectionType | INodeOutputConfiguration>)
: [];
} catch (e) {
console.warn('Could not calculate outputs dynamically for node: ', node.name);
}
Expand Down
13 changes: 4 additions & 9 deletions packages/workflow/src/workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,15 +697,10 @@ export class Workflow {
const outputs = NodeHelpers.getNodeOutputs(this, node, nodeType.description);
const nonMainConnectionTypes: NodeConnectionType[] = [];

// Defensive check: NodeHelpers.getNodeOutputs should always return an array,
// but in some edge cases (particularly during testing with incomplete node setup),
// it may return undefined or null
if (Array.isArray(outputs)) {
for (const output of outputs) {
const type = typeof output === 'string' ? output : output.type;
if (type !== NodeConnectionTypes.Main) {
nonMainConnectionTypes.push(type);
}
for (const output of outputs) {
const type = typeof output === 'string' ? output : output.type;
if (type !== NodeConnectionTypes.Main) {
nonMainConnectionTypes.push(type);
}
}

Expand Down
Loading