fix(core): Ensure getNodeOutputs always returns an array

[cstuncsik]

Summary

Fixing the root cause of why getParentMainInputNode had to check if the node output is an array, despite the types definition tells it's always an array.

Related Linear tickets, Github issues, and Community forum posts

PAY-3738

Review / Merge checklist

• PR title and summary are descriptive. (conventions)
• Docs updated or follow-up ticket created.
• Tests included.
• PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
packages/workflow/src/node-helpers.ts	62.50%	3 Missing ⚠️
packages/workflow/src/workflow.ts	75.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[cubic-dev-ai]

1 issue found across 2 files

_{React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

[cubic-dev-ai]

Rule violated: Prefer Typeguards over Type casting

Avoid using a type assertion for narrowing here. Introduce a type guard (e.g., isOutputsArray) to validate result’s element types, then assign after narrowing instead of (result as ...).

(Based on your team's feedback about avoiding '(...) as T[]' casts and replacing them with explicit type guards that check the response shape before narrowing.)

Prompt for AI agents

Address the following comment on packages/workflow/src/node-helpers.ts at line 1057:

<comment>Avoid using a type assertion for narrowing here. Introduce a type guard (e.g., isOutputsArray) to validate result’s element types, then assign after narrowing instead of `(result as ...)`.

(Based on your team&#39;s feedback about avoiding &#39;(...) as T[]&#39; casts and replacing them with explicit type guards that check the response shape before narrowing.)</comment>

<file context>
@@ -1047,12 +1047,15 @@ export function getNodeOutputs(
-			) || []) as NodeConnectionType[];
+			);
+			outputs = Array.isArray(result)
+				? (result as Array&lt;NodeConnectionType | INodeOutputConfiguration&gt;)
+				: [];
 		} catch (e) {
</file context>