[VPA] native sidecar support #8498
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jklaw90 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XL
jklaw90
force-pushed
the
julian/sidecars
branch
3 times, most recently
from
5eb981b to
0779cd7
Compare
jklaw90
force-pushed
the
julian/sidecars
branch
2 times, most recently
from
9ec60fb to
024b6b9
Compare
jklaw90
force-pushed
the
julian/sidecars
branch
from
024b6b9 to
a4748ee
Compare
k8s-ci-robot
added
size/XXL
jklaw90
force-pushed
the
julian/sidecars
branch
from
a732ccb to
f5d86c4
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Thanks for this! but since this is a major change which also introduce a feature flag I think it needs to go through a proper AEP. cc @adrianmoisey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Native sidecars are were added to k8s but haven't been added to vpa yet.
Which issue(s) this PR fixes:
Fixes # #7229
Special notes for your reviewer:
when loading prometheus history had to use live pod data to help determine container type. Wasn't sure if this is the best way
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: