add init sidecars to priority calcuations

Author: jklaw90

vertical-pod-autoscaler/pkg/updater/priority/priority_processor.go

@@ -42,7 +42,6 @@ func NewProcessor() PriorityProcessor {
 type defaultPriorityProcessor struct {
 }
 
-// TODO: jklaw90 support initContainers
 func (*defaultPriorityProcessor) GetUpdatePriority(pod *apiv1.Pod, vpa *vpa_types.VerticalPodAutoscaler,
 	recommendation *vpa_types.RecommendedPodResources) PodPriority {
 	outsideRecommendedRange := false
@@ -54,14 +53,14 @@ func (*defaultPriorityProcessor) GetUpdatePriority(pod *apiv1.Pod, vpa *vpa_type
 
 	hasObservedContainers, vpaContainerSet := parseVpaObservedContainers(pod)
 
-	for _, podContainer := range pod.Spec.Containers {
+	processContainer := func(podContainer apiv1.Container) {
 		if hasObservedContainers && !vpaContainerSet.Has(podContainer.Name) {
 			klog.V(4).InfoS("Not listed in VPA observed containers label. Skipping container priority calculations", "label", annotations.VpaObservedContainersLabel, "observedContainers", pod.GetAnnotations()[annotations.VpaObservedContainersLabel], "containerName", podContainer.Name, "vpa", klog.KObj(vpa))
-			continue
+			return
 		}
 		recommendedRequest := vpa_api_util.GetRecommendationForContainer(podContainer.Name, recommendation)
 		if recommendedRequest == nil {
-			continue
+			return
 		}
 		for resourceName, recommended := range recommendedRequest.Target {
 			totalRecommendedPerResource[resourceName] += recommended.MilliValue()
@@ -78,15 +77,19 @@ func (*defaultPriorityProcessor) GetUpdatePriority(pod *apiv1.Pod, vpa *vpa_type
 					outsideRecommendedRange = true
 				}
 			} else {
-				// Note: if the request is not specified, the container will use the
-				// namespace default request. Currently we ignore it and treat such
-				// containers as if they had 0 request. A more correct approach would
-				// be to always calculate the 'effective' request.
 				scaleUp = true
 				outsideRecommendedRange = true
 			}
 		}
 	}
+
+	for _, podContainer := range pod.Spec.Containers {
+		processContainer(podContainer)
+	}
+	for _, initContainer := range pod.Spec.InitContainers {
+		processContainer(initContainer)
+	}
+
 	resourceDiff := 0.0
 	for resource, totalRecommended := range totalRecommendedPerResource {
 		totalRequest := math.Max(float64(totalRequestPerResource[resource]), 1.0)