Skip to content

Conversation

Physic69
Copy link

@Physic69 Physic69 commented Aug 28, 2025

🦟 Bug fix

Fixes #

Summary

Updated links in get_started.md file, many were going to wrong links (before) & a minor error in number of figures spawned in shapes.sdf file.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. However, the links work fine as is and they are structured right now so that our tool (sphinx) generate the final URL properly. If the links don't work in the github markdown preview, that's okay. We just need to make sure the final html has the right links. Could you refert those changes?

@Physic69 Physic69 marked this pull request as draft August 28, 2025 17:40
@Physic69 Physic69 marked this pull request as ready for review August 28, 2025 17:56
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! However, let's wait to merge this until Jetty is actually released 😄

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants