Skip to content

fix a bug in FS.getattr #25122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix a bug in FS.getattr #25122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e8886a
fix a bug in FS.getattr
warrenfalk Aug 31, 2025
11c59de
implement suggested optimization
warrenfalk Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/libfs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,9 +983,10 @@ FS.staticInit();`;
var node = stream.node;
var getattr = stream.stream_ops.getattr;
var arg = getattr ? stream : node;
var obj = getattr ? stream.stream_ops : node.node_ops;
getattr ??= node.node_ops.getattr;
FS.checkOpExists(getattr, {{{ cDefs.EPERM }}})
return getattr(arg);
return getattr.call(obj, arg);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoodmane like this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think doSetAttr needs updating too.

I guess we don't have any test coverage for this because our FS callback don't use this.. :(

},
lstat(path) {
return FS.stat(path, true);
Expand Down