fix a bug in FS.getattr #25122
Open
fix a bug in FS.getattr #25122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of BFS's getattr requires a 'this' and calling it without this will always fail.
hoodmane
reviewed
Aug 31, 2025
src/lib/libfs.js
Outdated
| @@ -983,7 +983,7 @@ FS.staticInit();`; | |||
| var node = stream.node; | |||
| var getattr = stream.stream_ops.getattr; | |||
| var arg = getattr ? stream : node; | |||
| getattr ??= node.node_ops.getattr; | |||
| getattr ??= node.node_ops.getattr.bind(node.node_ops); | |||
| FS.checkOpExists(getattr, {{{ cDefs.EPERM }}}) | |||
| return getattr(arg); | |||
There was a problem hiding this comment.
How about getattr.call(node.node_ops, arg) here to avoid the temporary?
There was a problem hiding this comment.
The problem is that getattr might have come from either stream.stream_ops or node.node_ops and so the wrong this might break something else. I'm happy to rewrite the function, but I don't have enough experience with this project to test it thoroughly.
warrenfalk
commented
Aug 31, 2025
| FS.checkOpExists(getattr, {{{ cDefs.EPERM }}}) | ||
| return getattr(arg); | ||
| return getattr.call(obj, arg); |
There was a problem hiding this comment.
I think doSetAttr needs updating too.
I guess we don't have any test coverage for this because our FS callback don't use this.. :(
hoodmane
approved these changes
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of BFS's getattr requires a 'this' and calling it without this always fails.