Skip to content

add float16 encoding #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 11, 2025
Merged

add float16 encoding #22

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
257c7a5
add float16 encoding
borg323 Feb 21, 2023
b374924
Merge branch 'master' into fp16
borg323 Aug 26, 2025
9bacf03
typo fix
borg323 Aug 27, 2025
1bf3a46
move encoding to layers
borg323 Sep 8, 2025
3a5888c
review suggestion
borg323 Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion proto/net.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ message Weights {
optional float min_val = 1;
optional float max_val = 2;
optional bytes params = 3;
enum Encoding {
UNKNOWN_ENCODING = 0;
LINEAR16 = 1;
FLOAT16 = 2;
BFLOAT16 = 3;
}
optional Encoding encoding = 4;
repeated uint32 dims = 5;
}

message ConvBlock {
Expand Down Expand Up @@ -362,7 +370,7 @@ message Format {
UNKNOWN = 0;
LINEAR16 = 1;
}

// Any encoding specified in a Layer overides this.
optional Encoding weights_encoding = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can actually remove this field (replace with reserved 1) — it will be just ignored parsed by code that doesn't know it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this won't break older builds. But we can certainly do that after we move it to lc0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It likely would be fine, but let's keep for now.

// If network_format is missing, it's assumed to have
// INPUT_CLASSICAL_112_PLANE / OUTPUT_CLASSICAL / NETWORK_CLASSICAL format.
Expand Down