add float16 encoding #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almaudoh
reviewed
Feb 21, 2023
mooskagh
reviewed
Sep 9, 2025
| @@ -362,7 +370,7 @@ message Format { | |||
| UNKNOWN = 0; | |||
| LINEAR16 = 1; | |||
| } | |||
|
|
|||
| // Any encoding specified in a Layer overides this. | |||
| optional Encoding weights_encoding = 1; | |||
There was a problem hiding this comment.
We can actually remove this field (replace with reserved 1) — it will be just ignored parsed by code that doesn't know it.
There was a problem hiding this comment.
I'm not sure this won't break older builds. But we can certainly do that after we move it to lc0.
There was a problem hiding this comment.
It likely would be fine, but let's keep for now.
mooskagh
reviewed
Sep 9, 2025
mooskagh
approved these changes
Sep 11, 2025
| @@ -362,7 +370,7 @@ message Format { | |||
| UNKNOWN = 0; | |||
| LINEAR16 = 1; | |||
| } | |||
|
|
|||
| // Any encoding specified in a Layer overides this. | |||
| optional Encoding weights_encoding = 1; | |||
There was a problem hiding this comment.
It likely would be fine, but let's keep for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The encoding is moved to the Weights where it makes sense and can be used where the weights are passed around without needing to keep track of the encoding separately.Turns out it is more convenient to have the encoding in each
Layer.Also adds a
dimsfield perLayerto store the tensor dimensions.