boards: st: stm32n6570_dk: Clarify RAMLOAD instructions #96267
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
djiatsaf-st,
etienne-lms,
FRASTM,
gautierg-st,
GeorgeCGV,
marwaiehm-st and
mathieuchopstm
etienne-lms
reviewed
Sep 19, 2025
Comment on lines
254
to
255
| - Add CONFIG_XIP=n to the project configuration. | ||
| - Add ``-- -DSB_CONFIG_MCUBOOT_MODE_RAM_LOAD=y``to the build command. |
There was a problem hiding this comment.
Suggested change
| - Add CONFIG_XIP=n to the project configuration. | |
| - Add ``-- -DSB_CONFIG_MCUBOOT_MODE_RAM_LOAD=y``to the build command. | |
| * Add ``CONFIG_XIP=n`` to the project configuration. | |
| * Add ``-- -DSB_CONFIG_MCUBOOT_MODE_RAM_LOAD=y``to the build command. |
Would that fix the CI doc build failure?
Maybe:
.. zephyr-app-commands::
:zephyr-app: samples/hello_world
:board: stm32n6570_dk
:west-args: --sysbuild -- -DCONFIG_XIP=n -DSB_CONFIG_MCUBOOT_MODE_RAM_LOAD=y
:goals: build flashThere was a problem hiding this comment.
That's worth having a try
| By default, application runs in XIP mode. Add ``-DSB_CONFIG_MCUBOOT_MODE_RAM_LOAD=y`` | ||
| to use RAMLOAD mode. | ||
| .. note:: | ||
| By default, application runs in XIP mode, to use RAMLOAD mode: |
There was a problem hiding this comment.
Suggested change
| By default, application runs in XIP mode, to use RAMLOAD mode: | |
| By default, applications runs in XIP mode. To use RAMLOAD mode: |
There was a problem hiding this comment.
+ with Etienne's suggestion, could be:
Suggested change
| By default, application runs in XIP mode, to use RAMLOAD mode: | |
| By default, application runs in XIP mode. To use RAMLOAD mode, build using the following command instead: | |
| .. zephyr-app-commands:: <etc> |
There was a problem hiding this comment.
Done, but I kept application in the singular form.
erwango
force-pushed
the
doc_n6_ramload_fix
branch
from
4729e68 to
73edf7b
Compare
Review RAMLOAD section to hopefully avoid possible confusions. Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
erwango
force-pushed
the
doc_n6_ramload_fix
branch
from
73edf7b to
ec25b40
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review RAMLOAD section to hopefully avoid possible confusions.