-
Notifications
You must be signed in to change notification settings - Fork 7.9k
BOARD: Enable PCA6408 on FRDM-IMX93 board #96257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CkovMk
wants to merge
6
commits into
zephyrproject-rtos:main
Choose a base branch
from
CkovMk:pr/enable-pca6408-on-frdm-imx93
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
BOARD: Enable PCA6408 on FRDM-IMX93 board #96257
CkovMk
wants to merge
6
commits into
zephyrproject-rtos:main
from
CkovMk:pr/enable-pca6408-on-frdm-imx93
+704
−598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support for pca9538, pcal9539. Add support for pcal6408 and pcal6416, which is originally supported by pcal64xxa driver. These device has the same register layout as pcal9538 and pcal9539 respectively, which means they can be seamlessly supported by pca_series driver. Signed-off-by: Chekhov Ma <chekhov.ma@nxp.com>
55f7029
to
cb4c4cf
Compare
The reset function is originally designed to have no return value. If the GPIO toggle fails, there's no indication for failure until I2C transaction fails. Account for this by adding return value to the reset function. Signed-off-by: Chekhov Ma <chekhov.ma@nxp.com>
Enables pca_series driver to set drive strength for part no with PCA_HAS_LATCH capability. Signed-off-by: Chekhov Ma <chekhov.ma@nxp.com>
On certain platforms I2C is not enabled by default, causing build error. Change pca_series driver to select I2C. Signed-off-by: Chekhov Ma <chekhov.ma@nxp.com>
pca6416a driver can be replaced by pca_series driver, which covers a larger number of devices. Signed-off-by: Chekhov Ma <chekhov.ma@nxp.com>
Preserving pca_series commits for CI check. Once CI passes I will drop commits from the other PR and make it clean for review. |
cb4c4cf
to
db17edc
Compare
Enable pcal6408 gpio expander on FRDM-IMX93 board. This expander has its reset pin controlled by another expander, and both expanders is driven by the same pca_series driver. To guarentee correct init order, pcal6408 is set to deferred init in a board init function. Signed-off-by: Chekhov Ma <chekhov.ma@nxp.com>
db17edc
to
738648a
Compare
re-trigger ci |
|
CI failure caused by regression: #96158, not the scope of this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #93242