Skip to content

Conversation

lll-phill-lll
Copy link
Member

@lll-phill-lll lll-phill-lll commented Sep 8, 2025

(cherry picked from commit e6d6306)

Changelog entry

Wakeup callback is called from multiple threads. So, it shouldn't change the inner state of the tasks runner.
fixes #24148
...

Changelog category

  • Bugfix

Description for reviewers

...

@lll-phill-lll lll-phill-lll requested a review from a team as a code owner September 8, 2025 10:23
Copy link

github-actions bot commented Sep 8, 2025

🟢 2025-09-08 10:30:57 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Sep 8, 2025

2025-09-08 10:24:58 UTC Pre-commit check linux-x86_64-release-asan for 4f10649 has started.
2025-09-08 10:25:15 UTC Artifacts will be uploaded here
2025-09-08 10:28:21 UTC ya make is running...
🟡 2025-09-08 11:47:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14590 14377 0 46 134 33

2025-09-08 11:49:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-09-08 12:02:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
271 (only retried tests) 204 0 7 26 34

2025-09-08 12:02:57 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-09-08 12:16:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
94 (only retried tests) 34 0 4 26 30

🟢 2025-09-08 12:16:42 UTC Build successful.
🟢 2025-09-08 12:17:06 UTC ydbd size 3.8 GiB changed* by -928 Bytes, which is <= 0 Bytes vs stable-25-2: OK

ydbd size dash stable-25-2: e512b31 merge: 4f10649 diff diff %
ydbd size 4 045 439 464 Bytes 4 045 438 536 Bytes -928 Bytes -0.000%
ydbd stripped size 1 408 437 112 Bytes 1 408 436 280 Bytes -832 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 8, 2025

2025-09-08 10:26:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4f10649 has started.
2025-09-08 10:26:38 UTC Artifacts will be uploaded here
2025-09-08 10:29:39 UTC ya make is running...
🟡 2025-09-08 11:46:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
35668 33143 0 6 2472 47

2025-09-08 11:49:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-08 12:05:07 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 53 0 0 2 43

🟢 2025-09-08 12:05:15 UTC Build successful.
🟢 2025-09-08 12:05:33 UTC ydbd size 2.2 GiB changed* by +160 Bytes, which is < 100.0 KiB vs stable-25-2: OK

ydbd size dash stable-25-2: e512b31 merge: 4f10649 diff diff %
ydbd size 2 324 669 848 Bytes 2 324 670 008 Bytes +160 Bytes +0.000%
ydbd stripped size 487 222 696 Bytes 487 222 696 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lll-phill-lll lll-phill-lll merged commit bfe243c into ydb-platform:stable-25-2 Sep 8, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stable-25-2-1, tsan: ydb/core/kqp/ut/spilling/KqpScanSpilling.SelfJoin potential racing when WakeupCallback is called from TDqComputeStorageActor
2 participants