-
Notifications
You must be signed in to change notification settings - Fork 718
YQ-4482 added streaming queries into scheme shard #22603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YQ-4482 added streaming queries into scheme shard #22603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for streaming queries as a new entity type in YDB's scheme shard. This is part of a larger effort to implement streaming query functionality within YDB.
Key changes include:
- Added
StreamingQuery
as a new path type in the schema with full CRUD operations (Create, Read, Update, Delete) - Integrated streaming query support into CLI, SDK, and various system components
- Added comprehensive test coverage for streaming query operations
Reviewed Changes
Copilot reviewed 53 out of 53 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
flat_schemeshard.schema | Added StreamingQuery table definition to schema |
ydb_backup_ut.cpp | Added streaming query path type handling in backup tests |
scheme.cpp/scheme.h | Added StreamingQuery enum value and conversion logic |
print_utils.cpp | Added display formatting for streaming query entries |
ydb_schema.cpp | Added streaming query type mapping for completions |
schema.cpp/kicli.h | Added streaming query drop operation and enum support |
ydb_scheme.proto | Added STREAMING_QUERY enum value |
core_ydb_impl.h | Added streaming query to special case mappings |
viewer.proto/browse.h | Added streaming query viewer support |
schemereq.cpp | Added streaming query operation handling |
ya.make | Added streaming query source files and test directories |
ut_system_names.cpp | Added streaming query creation test case |
Multiple schemeshard files | Core implementation of streaming query operations |
Multiple test files | Comprehensive test coverage for streaming query functionality |
🟢 |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SDK -ok
0078f26
to
9a19fe6
Compare
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
9a19fe6
to
37de9fa
Compare
⚪ |
7901172
to
c70d179
Compare
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ |
⚪ |
c9472ea
to
0f7b535
Compare
⚪ |
⚪ |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Added new entity
streaming query
into scheme shard, also added this entry into cli / sdk (part of streaming queries support)Changelog category
Description for reviewers