Skip to content

Conversation

wangxiyuan
Copy link
Collaborator

@wangxiyuan wangxiyuan commented Sep 14, 2025

Add release note for v0.10.2rc1

Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 14, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the repository for the v0.10.2rc1 release, including version bumps in READMEs, configuration files, and documentation, as well as adding the new release notes. My review found a couple of potential issues: a typo in a markdown table that could affect rendering, and an inconsistent version string format in the documentation configuration which might cause problems for users following installation instructions. I've provided suggestions to correct these.

@@ -41,7 +42,8 @@ Following is the Release Compatibility Matrix for vLLM Ascend Plugin:
### release window

| Date | Event |
|------------|-------------------------------------------|
|------------|-------------------------------------------|、
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There appears to be a typo in the markdown table separator. The character at the end of the line is not standard for markdown tables and may cause rendering issues, making the release schedule table unreadable.

Suggested change
|------------|-------------------------------------------|
|------------|-------------------------------------------|

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this

'pip_vllm_ascend_version': "0.10.1rc1",
'pip_vllm_version': "0.10.1.1",
'pip_vllm_ascend_version': "0.10.2rc1",
'pip_vllm_version': "v0.10.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version format for pip_vllm_version seems inconsistent. A v prefix has been added, but pip versions typically do not have this prefix. The previous value and the related pip_vllm_ascend_version do not have a v prefix. This inconsistency could lead to issues in scripts or documentation that rely on this value for pip install commands.

Suggested change
'pip_vllm_version': "v0.10.2",
'pip_vllm_version': "0.10.2",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the v should remove

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Copy link
Collaborator

@Yikun Yikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except inline comments

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
@Yikun Yikun merged commit 048bfd5 into vllm-project:main Sep 15, 2025
14 checks passed
@Yikun Yikun added the ready read for review label Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready read for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants