-
Notifications
You must be signed in to change notification settings - Fork 435
[Release] Add release note for v0.10.2rc1 #2921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the repository for the v0.10.2rc1
release, including version bumps in READMEs, configuration files, and documentation, as well as adding the new release notes. My review found a couple of potential issues: a typo in a markdown table that could affect rendering, and an inconsistent version string format in the documentation configuration which might cause problems for users following installation instructions. I've provided suggestions to correct these.
@@ -41,7 +42,8 @@ Following is the Release Compatibility Matrix for vLLM Ascend Plugin: | |||
### release window | |||
|
|||
| Date | Event | | |||
|------------|-------------------------------------------| | |||
|------------|-------------------------------------------|、 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a typo in the markdown table separator. The character 、
at the end of the line is not standard for markdown tables and may cause rendering issues, making the release schedule table unreadable.
|------------|-------------------------------------------|、 | |
|------------|-------------------------------------------| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this
docs/source/conf.py
Outdated
'pip_vllm_ascend_version': "0.10.1rc1", | ||
'pip_vllm_version': "0.10.1.1", | ||
'pip_vllm_ascend_version': "0.10.2rc1", | ||
'pip_vllm_version': "v0.10.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version format for pip_vllm_version
seems inconsistent. A v
prefix has been added, but pip
versions typically do not have this prefix. The previous value and the related pip_vllm_ascend_version
do not have a v
prefix. This inconsistency could lead to issues in scripts or documentation that rely on this value for pip install
commands.
'pip_vllm_version': "v0.10.2", | |
'pip_vllm_version': "0.10.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the v should remove
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
1b14e1e
to
b448ccd
Compare
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
841dcb3
to
22ff354
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except inline comments
Add release note for v0.10.2rc1