Skip to content

Conversation

xleoken
Copy link
Contributor

@xleoken xleoken commented Sep 10, 2025

What this PR does / why we need it?

Modify the _send_done_recv_signal method to properly handle socket cleanup by using a socket_valid flag.

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a socket_valid flag to improve socket cleanup in the _send_done_recv_signal method. This is a good step towards preventing faulty sockets from being reused. However, the current implementation only considers the case of an invalid ACK response. My review highlights that other exceptions during socket communication are not handled, which could still lead to a broken socket being returned to the connection pool. I've suggested a more comprehensive exception handling strategy to make the socket cleanup logic more robust.

Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

…eanup by using a socket_valid flag

Signed-off-by: xleoken <xleoken@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant