Add test for undefined values equality checking #3270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
vpr/test/test_undefined_value.cpp
Outdated
| #include "arch_types.h" | ||
| #include "librrgraph_types.h" | ||
|
|
||
| // Make sure the 'unkown value' constants in VPR, LibArchFPGA and LibRRGraph are all equal to the same value (-1) |
There was a problem hiding this comment.
"unkown" -> "unknown"
Also I think you add a bit on why. Just something simple like "these should be equal since they are sometimes intermixed by mistake".
AmirhosseinPoolad
force-pushed
the
unknown_const_assert
branch
from
3d0da0b to
586af06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a static_assert to make sure the three undefined value constants are all equal to -1.