Skip to content

But what if we are already resolved to the correct value. #83542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from
+9 −1
Draft

But what if we are already resolved to the correct value. #83542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion turbopack/crates/turbo-tasks/src/raw_vc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,10 @@ impl RawVc {
}

async fn resolve_inner(self, mut consistency: ReadConsistency) -> Result<RawVc> {
// Handle this first to avoid taking a reference to turbo_tasks
if matches!(self, RawVc::TaskCell(_, _)) {
return Ok(self);
}
let tt = turbo_tasks();
let mut current = self;
let mut notified = false;
Expand Down Expand Up @@ -237,8 +241,12 @@ impl RawVc {
/// Convert a potentially local `RawVc` into a non-local `RawVc`. This is a subset of resolution
/// resolution, because the returned `RawVc` can be a `TaskOutput`.
pub(crate) async fn to_non_local(self) -> Result<RawVc> {
let tt = turbo_tasks();
// Handle this first to avoid taking a reference to turbo_tasks
if !matches!(self, RawVc::LocalOutput(_, _, _)) {
return Ok(self);
}
let mut current = self;
let tt = turbo_tasks();
loop {
match current {
RawVc::LocalOutput(execution_id, local_task_id, ..) => {
Expand Down
Loading