Skip to content

fix: various layout+styling issues #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix: various layout+styling issues #1104

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fb43f44
Fix issues with sidenav layout in mobile view
JurekMueller Sep 18, 2025
7b12a49
Fix inconsistent header padding in invoice table
JurekMueller Sep 18, 2025
0c677f8
Fix acme logo on login page in mobile view
JurekMueller Sep 18, 2025
e28628a
Actually disable login button while pending
JurekMueller Sep 18, 2025
5268948
Add missing id to search input
JurekMueller Sep 18, 2025
1a38a51
Add intended peer focus color to customer select icon in invoice forms
JurekMueller Sep 18, 2025
cdc9237
Remove ineffective font-normal from <thead> in invoice tables:
JurekMueller Sep 18, 2025
7a87c50
Remove unnecessary utilities from login page
JurekMueller Sep 18, 2025
3a17d9a
Remove ineffective placeholder color from select in the invoice forms
JurekMueller Sep 18, 2025
41112b3
Remove leftover grow
JurekMueller Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dashboard/final-example/app/login/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import { Suspense } from 'react';
export default function LoginPage() {
return (
<main className="flex items-center justify-center md:h-screen">
<div className="relative mx-auto flex w-full max-w-[400px] flex-col space-y-2.5 p-4 md:-mt-32">
<div className="flex w-full max-w-[400px] flex-col space-y-2.5 p-4 md:-mt-32">
<div className="flex h-20 w-full items-end rounded-lg bg-blue-500 p-3 md:h-36">
<div className="w-32 text-white md:w-36">
<div className="text-white w-36">
<AcmeLogo />
</div>
</div>
Expand Down
5 changes: 3 additions & 2 deletions dashboard/final-example/app/ui/dashboard/sidenav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default function SideNav() {
className="mb-2 flex h-20 items-end justify-start rounded-md bg-blue-600 p-4 md:h-40"
href="/"
>
<div className="w-32 text-white md:w-40">
<div className="text-white w-40">
<AcmeLogo />
</div>
</Link>
Expand All @@ -23,8 +23,9 @@ export default function SideNav() {
'use server';
await signOut({ redirectTo: '/' });
}}
className="grow md:flex-none"
>
<button className="flex h-[48px] w-full grow items-center justify-center gap-2 rounded-md bg-gray-50 p-3 text-sm font-medium hover:bg-sky-100 hover:text-blue-600 md:flex-none md:justify-start md:p-2 md:px-3">
<button className="flex h-[48px] w-full grow items-center justify-center gap-2 rounded-md bg-gray-50 p-3 text-sm font-medium hover:bg-sky-100 hover:text-blue-600 md:justify-start md:p-2 md:px-3">
<PowerIcon className="w-6" />
<div className="hidden md:block">Sign Out</div>
</button>
Expand Down
4 changes: 2 additions & 2 deletions dashboard/final-example/app/ui/invoices/create-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default function Form({ customers }: { customers: CustomerField[] }) {
<select
id="customer"
name="customerId"
className="peer block w-full cursor-pointer rounded-md border border-gray-200 py-2 pl-10 text-sm outline-2 placeholder:text-gray-500"
className="peer block w-full cursor-pointer rounded-md border border-gray-200 py-2 pl-10 text-sm outline-2"
defaultValue=""
aria-describedby="customer-error"
>
Expand All @@ -41,7 +41,7 @@ export default function Form({ customers }: { customers: CustomerField[] }) {
</option>
))}
</select>
<UserCircleIcon className="pointer-events-none absolute left-3 top-1/2 h-[18px] w-[18px] -translate-y-1/2 text-gray-500" />
<UserCircleIcon className="pointer-events-none absolute left-3 top-1/2 h-[18px] w-[18px] -translate-y-1/2 text-gray-500 peer-focus:text-gray-900" />
</div>

<div id="customer-error" aria-live="polite" aria-atomic="true">
Expand Down
4 changes: 2 additions & 2 deletions dashboard/final-example/app/ui/invoices/edit-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export default function EditInvoiceForm({
<select
id="customer"
name="customerId"
className="peer block w-full cursor-pointer rounded-md border border-gray-200 py-2 pl-10 text-sm outline-2 placeholder:text-gray-500"
className="peer block w-full cursor-pointer rounded-md border border-gray-200 py-2 pl-10 text-sm outline-2"
defaultValue={invoice.customer_id}
aria-describedby="customer-error"
>
Expand All @@ -48,7 +48,7 @@ export default function EditInvoiceForm({
</option>
))}
</select>
<UserCircleIcon className="pointer-events-none absolute left-3 top-1/2 h-[18px] w-[18px] -translate-y-1/2 text-gray-500" />
<UserCircleIcon className="pointer-events-none absolute left-3 top-1/2 h-[18px] w-[18px] -translate-y-1/2 text-gray-500 peer-focus:text-gray-900" />
</div>

<div id="customer-error" aria-live="polite" aria-atomic="true">
Expand Down
4 changes: 2 additions & 2 deletions dashboard/final-example/app/ui/invoices/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ export default async function InvoicesTable({
))}
</div>
<table className="hidden min-w-full text-gray-900 md:table">
<thead className="rounded-lg text-left text-sm font-normal">
<thead className="rounded-lg text-left text-sm">
<tr>
<th scope="col" className="px-4 py-5 font-medium sm:pl-6">
<th scope="col" className="pr-3 pl-6 py-5 font-medium">
Customer
</th>
<th scope="col" className="px-3 py-5 font-medium">
Expand Down
2 changes: 1 addition & 1 deletion dashboard/final-example/app/ui/login-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export default function LoginForm() {
</div>
</div>
<input type="hidden" name="redirectTo" value={callbackUrl} />
<Button className="mt-4 w-full" aria-disabled={isPending}>
<Button className="mt-4 w-full" disabled={isPending} aria-disabled={isPending}>
Log in <ArrowRightIcon className="ml-auto h-5 w-5 text-gray-50" />
</Button>
<div
Expand Down
1 change: 1 addition & 0 deletions dashboard/final-example/app/ui/search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export default function Search({ placeholder }: { placeholder: string }) {
Search
</label>
<input
id="search"
className="peer block w-full rounded-md border border-gray-200 py-[9px] pl-10 text-sm outline-2 placeholder:text-gray-500"
placeholder={placeholder}
onChange={(e) => {
Expand Down
4 changes: 2 additions & 2 deletions dashboard/final-example/app/ui/skeletons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@ export function InvoicesTableSkeleton() {
<InvoicesMobileSkeleton />
</div>
<table className="hidden min-w-full text-gray-900 md:table">
<thead className="rounded-lg text-left text-sm font-normal">
<thead className="rounded-lg text-left text-sm">
<tr>
<th scope="col" className="px-4 py-5 font-medium sm:pl-6">
<th scope="col" className="pr-3 pl-6 py-5 font-medium">
Customer
</th>
<th scope="col" className="px-3 py-5 font-medium">
Expand Down
6 changes: 3 additions & 3 deletions dashboard/starter-example/app/ui/dashboard/sidenav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ export default function SideNav() {
className="mb-2 flex h-20 items-end justify-start rounded-md bg-blue-600 p-4 md:h-40"
href="/"
>
<div className="w-32 text-white md:w-40">
<div className="text-white w-40">
<AcmeLogo />
</div>
</Link>
<div className="flex grow flex-row justify-between space-x-2 md:flex-col md:space-x-0 md:space-y-2">
<NavLinks />
<div className="hidden h-auto w-full grow rounded-md bg-gray-50 md:block"></div>
<form>
<button className="flex h-[48px] w-full grow items-center justify-center gap-2 rounded-md bg-gray-50 p-3 text-sm font-medium hover:bg-sky-100 hover:text-blue-600 md:flex-none md:justify-start md:p-2 md:px-3">
<form className="grow md:flex-none">
<button className="flex h-[48px] w-full items-center justify-center gap-2 rounded-md bg-gray-50 p-3 text-sm font-medium hover:bg-sky-100 hover:text-blue-600 md:justify-start md:p-2 md:px-3">
<PowerIcon className="w-6" />
<div className="hidden md:block">Sign Out</div>
</button>
Expand Down
4 changes: 2 additions & 2 deletions dashboard/starter-example/app/ui/invoices/create-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default function Form({ customers }: { customers: CustomerField[] }) {
<select
id="customer"
name="customerId"
className="peer block w-full cursor-pointer rounded-md border border-gray-200 py-2 pl-10 text-sm outline-2 placeholder:text-gray-500"
className="peer block w-full cursor-pointer rounded-md border border-gray-200 py-2 pl-10 text-sm outline-2"
defaultValue=""
>
<option value="" disabled>
Expand All @@ -33,7 +33,7 @@ export default function Form({ customers }: { customers: CustomerField[] }) {
</option>
))}
</select>
<UserCircleIcon className="pointer-events-none absolute left-3 top-1/2 h-[18px] w-[18px] -translate-y-1/2 text-gray-500" />
<UserCircleIcon className="pointer-events-none absolute left-3 top-1/2 h-[18px] w-[18px] -translate-y-1/2 text-gray-500 peer-focus:text-gray-900" />
</div>
</div>

Expand Down
4 changes: 2 additions & 2 deletions dashboard/starter-example/app/ui/invoices/edit-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default function EditInvoiceForm({
<select
id="customer"
name="customerId"
className="peer block w-full cursor-pointer rounded-md border border-gray-200 py-2 pl-10 text-sm outline-2 placeholder:text-gray-500"
className="peer block w-full cursor-pointer rounded-md border border-gray-200 py-2 pl-10 text-sm outline-2"
defaultValue={invoice.customer_id}
>
<option value="" disabled>
Expand All @@ -41,7 +41,7 @@ export default function EditInvoiceForm({
</option>
))}
</select>
<UserCircleIcon className="pointer-events-none absolute left-3 top-1/2 h-[18px] w-[18px] -translate-y-1/2 text-gray-500" />
<UserCircleIcon className="pointer-events-none absolute left-3 top-1/2 h-[18px] w-[18px] -translate-y-1/2 text-gray-500 peer-focus:text-gray-900" />
</div>
</div>

Expand Down
4 changes: 2 additions & 2 deletions dashboard/starter-example/app/ui/invoices/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ export default async function InvoicesTable({
))}
</div>
<table className="hidden min-w-full text-gray-900 md:table">
<thead className="rounded-lg text-left text-sm font-normal">
<thead className="rounded-lg text-left text-sm">
<tr>
<th scope="col" className="px-4 py-5 font-medium sm:pl-6">
<th scope="col" className="pr-3 pl-6 py-5 font-medium">
Customer
</th>
<th scope="col" className="px-3 py-5 font-medium">
Expand Down
1 change: 1 addition & 0 deletions dashboard/starter-example/app/ui/search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export default function Search({ placeholder }: { placeholder: string }) {
Search
</label>
<input
id="search"
className="peer block w-full rounded-md border border-gray-200 py-[9px] pl-10 text-sm outline-2 placeholder:text-gray-500"
placeholder={placeholder}
/>
Expand Down
4 changes: 2 additions & 2 deletions dashboard/starter-example/app/ui/skeletons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@ export function InvoicesTableSkeleton() {
<InvoicesMobileSkeleton />
</div>
<table className="hidden min-w-full text-gray-900 md:table">
<thead className="rounded-lg text-left text-sm font-normal">
<thead className="rounded-lg text-left text-sm">
<tr>
<th scope="col" className="px-4 py-5 font-medium sm:pl-6">
<th scope="col" className="pr-3 pl-6 py-5 font-medium">
Customer
</th>
<th scope="col" className="px-3 py-5 font-medium">
Expand Down