Cluster: Retry command on receiving specific errors

[adam-fowler]

The list of errors that cause a retry are TRYAGAIN, MASTERDOWN, CLUSTERDOWN and LOADING. This list was obtained from valkey-glide. The retry wait time calculation was also taken from valkey-glide

[github-actions]

✅ Pull request no significant performance differences ✅

Summary

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host 'a2f8e7f1afb9' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

ValkeyBenchmarks

Client: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	77	80	80	81	83	83	83	6
pull_request	77	78	79	81	81	81	81	6
Δ	0	-2	-1	0	-2	-2	-2	0
Improvement %	0	2	1	0	2	2	2	0

Client: GET benchmark | parallel 20 | 20 concurrent connections metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	94	96	99	101	103	104	104	25
pull_request	92	96	98	100	102	107	107	24
Δ	-2	0	-1	-1	-1	3	3	-1
Improvement %	2	0	1	1	1	-3	-3	-1

Connection: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	4	4	4	4	4	4	4	8
pull_request	4	4	4	4	4	4	4	8
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: Pipeline benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	36	36	37	37	37	37	37	4
pull_request	36	36	37	37	37	37	37	5
Δ	0	0	0	0	0	0	0	1
Improvement %	0	0	0	0	0	0	0	1

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	19
pull_request	0	0	0	0	0	0	0	18
Δ	0	0	0	0	0	0	0	-1
Improvement %	0	0	0	0	0	0	0	-1

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	753
pull_request	0	0	0	0	0	0	0	749
Δ	0	0	0	0	0	0	0	-4
Improvement %	0	0	0	0	0	0	0	-4

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	1895
pull_request	0	0	0	0	0	0	0	1895
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	361
pull_request	0	0	0	0	0	0	0	356
Δ	0	0	0	0	0	0	0	-5
Improvement %	0	0	0	0	0	0	0	-5