-
Notifications
You must be signed in to change notification settings - Fork 6
Chore/update deps #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
friedger
wants to merge
2
commits into
uport-project:develop
Choose a base branch
from
friedger:chore/update_deps
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,13 @@ | ||
package me.uport.sdk.jwt.model | ||
|
||
import kotlinx.serialization.Decoder | ||
import kotlinx.serialization.Encoder | ||
import kotlinx.serialization.ImplicitReflectionSerializer | ||
import kotlinx.serialization.ExperimentalSerializationApi | ||
import kotlinx.serialization.KSerializer | ||
import kotlinx.serialization.PolymorphicKind | ||
import kotlinx.serialization.SerialDescriptor | ||
import kotlinx.serialization.encode | ||
import kotlinx.serialization.json.Json | ||
import kotlinx.serialization.json.JsonArray | ||
import kotlinx.serialization.json.JsonConfiguration | ||
import kotlinx.serialization.json.JsonElement | ||
import kotlinx.serialization.json.JsonLiteral | ||
import kotlinx.serialization.json.JsonNull | ||
import kotlinx.serialization.json.JsonObject | ||
import kotlinx.serialization.json.JsonObjectSerializer | ||
import kotlinx.serialization.json.JsonPrimitive | ||
import kotlinx.serialization.modules.getContextualOrDefault | ||
import kotlinx.serialization.descriptors.* | ||
import kotlinx.serialization.encoding.Decoder | ||
import kotlinx.serialization.encoding.Encoder | ||
import kotlinx.serialization.json.* | ||
import kotlinx.serialization.json.Json.Default.encodeToJsonElement | ||
import kotlin.reflect.typeOf | ||
|
||
/** | ||
* This handles serialization and deserialization of arbitrary JSON trees represented as | ||
|
@@ -33,12 +24,10 @@ object ArbitraryMapSerializer : KSerializer<Map<String, Any?>> { | |
//////////////////////// | ||
// converting to Json // | ||
//////////////////////// | ||
@ImplicitReflectionSerializer | ||
private fun Map<*, *>.toJsonObject(): JsonObject = JsonObject(map { | ||
it.key.toString() to it.value.toJsonElement() | ||
}.toMap()) | ||
|
||
@ImplicitReflectionSerializer | ||
private fun Any?.toJsonElement(): JsonElement = when (this) { | ||
null -> JsonNull | ||
is Number -> JsonPrimitive(this) | ||
|
@@ -49,25 +38,24 @@ object ArbitraryMapSerializer : KSerializer<Map<String, Any?>> { | |
is Array<*> -> JsonArray(this.map { it.toJsonElement() }) | ||
else -> { | ||
//supporting classes that declare serializers | ||
val jsonParser = Json(JsonConfiguration.Stable) | ||
val serializer = jsonParser.context.getContextualOrDefault(this) | ||
jsonParser.toJson(serializer, this) | ||
val jsonParser = Json | ||
jsonParser.encodeToJsonElement(this) | ||
} | ||
} | ||
|
||
////////////////////////////////////////////////// | ||
// converting back to primitives (no type info) // | ||
////////////////////////////////////////////////// | ||
private fun JsonObject.toPrimitiveMap(): Map<String, Any?> = | ||
this.content.map { | ||
this.map { | ||
it.key to it.value.toPrimitive() | ||
}.toMap() | ||
|
||
private fun JsonElement.toPrimitive(): Any? = when (this) { | ||
is JsonNull -> null | ||
is JsonObject -> this.toPrimitiveMap() | ||
is JsonArray -> this.map { it.toPrimitive() } | ||
is JsonLiteral -> { | ||
is JsonPrimitive -> { | ||
if (isString) { | ||
contentOrNull | ||
} else { | ||
|
@@ -78,16 +66,19 @@ object ArbitraryMapSerializer : KSerializer<Map<String, Any?>> { | |
} | ||
|
||
override fun deserialize(decoder: Decoder): Map<String, Any?> { | ||
val asJsonObject: JsonObject = decoder.decodeSerializableValue(JsonObjectSerializer) | ||
assert(decoder is JsonDecoder) {"Only JsonDecoder supported, found " + decoder::class.java} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this safe to assert? |
||
val asJsonObject: JsonObject = (decoder as JsonDecoder).decodeJsonElement().jsonObject | ||
return asJsonObject.toPrimitiveMap() | ||
} | ||
|
||
@ExperimentalSerializationApi | ||
override val descriptor: SerialDescriptor | ||
get() = SerialDescriptor("arbitrary map", PolymorphicKind.OPEN) | ||
get() = mapSerialDescriptor(PrimitiveSerialDescriptor("key", PrimitiveKind.STRING), | ||
PrimitiveSerialDescriptor("value", PrimitiveKind.STRING)) | ||
|
||
@ImplicitReflectionSerializer | ||
override fun serialize(encoder: Encoder, value: Map<String, Any?>) { | ||
assert(encoder is JsonEncoder) {"Only JsonEncoder support, found " + encoder::class.java} | ||
val asJsonObj: JsonObject = value.toJsonObject() | ||
encoder.encode(JsonObjectSerializer, asJsonObj) | ||
(encoder as JsonEncoder).encodeJsonElement(asJsonObj) | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I am missing a serializer here. Any ideas what is required? @mirceanis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really :(
I am not familiar with the latest kotlinx.serialization requirements, unfortunately.