add UC_CTL go bindings #2204
Open
add UC_CTL go bindings #2204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, sorry for late. The changes look good. Could you rebase it to dev? |
|
Hello @wtdcode, There you go, I changed the targeting branch to dev and upgraded the commit to match the updated dev branch. Hope this is better. |
| @@ -187,14 +219,26 @@ func (u *uc) MemWrite(addr uint64, data []byte) error { | |||
| if len(data) == 0 { | |||
| return nil | |||
| } | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
you missed some git merge/rebase artifacts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a straightforward pull request that adds UC_CTL bindings to the Go API. I needed these functions for a project I'm working on, so I decided to contribute them here.