Support column properties with jdbc connector #26561
Conversation
|
@ebyhr @chenjian2664 Could you help review it? Thanks |
hqbhoho
requested review from
chenjian2664 and
ebyhr
and removed request for
chenjian2664
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcColumnHandle.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlMetadata.java
Outdated
Show resolved
Hide resolved
hqbhoho
force-pushed
the
feature/support_column_properties_with_jdbc_connector
branch
2 times, most recently
from
521ff3e to
cf6c266
Compare
hqbhoho
force-pushed
the
feature/support_column_properties_with_jdbc_connector
branch
2 times, most recently
from
64d84a9 to
9ce5fcb
Compare
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcColumnHandle.java
Outdated
Show resolved
Hide resolved
| public void testCreateTableWithAutoIncrementColumn() | ||
| { | ||
| verifyCreateTableDefinition( | ||
| "(a tinyint NOT NULL WITH (auto_increment = true), b bigint, c bigint) WITH (primary_key = ARRAY['a'])", |
There was a problem hiding this comment.
Does it allow specifying auto_increment as false?
There was a problem hiding this comment.
You are right, we need add a check to prevent the creation of tables in Trino using WITH (auto_increment = false).It is meaningless.
plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlClient.java
Outdated
Show resolved
Hide resolved
| * Returns the estimated size of a property value. | ||
| * <p> | ||
| * Supported types are the same as those accepted by | ||
| * {@link io.trino.metadata.PropertyUtil#toExpression}. |
There was a problem hiding this comment.
Why accept the same as PropertyUtil#toExpression ?
There was a problem hiding this comment.
SHOW CREATE TABLE will use PropertyUtil#toExpression parse property value to Expression. So here, I want to restrict the types of property values. I should put this check in JdbcColumnHandle#Constructor and then estimatedObjectSizeOf only needs to support the legal types. Or do you have any better suggestions
Thank you for your feedback! Currently, the To address this, I will implement a validation check to prevent such table creation attempts and add corresponding test cases to ensure the functionality works as expected |
hqbhoho
force-pushed
the
feature/support_column_properties_with_jdbc_connector
branch
from
9ce5fcb to
aba59d3
Compare
hqbhoho
force-pushed
the
feature/support_column_properties_with_jdbc_connector
branch
from
aba59d3 to
b5c1436
Compare
Description
ReOpening #25174 since it went stale.
Add column properties for base jdbc connector to support auto_increment and other column attribute.
When running SHOW CREATE TABLE include column properties present for these column attribute.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: