Fix: parsing quoted built-in data types #5810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
reviewed
Sep 5, 2025
treysp
force-pushed
the
trey/quoted-types
branch
from
26159a3 to
7de5fb9
Compare
VaggelisD
reviewed
Sep 8, 2025
| self.raise_error("Unexpected identifier", self._prev) | ||
| try: | ||
| tokens = self.dialect.tokenize(identifier.name) | ||
| except TokenError: |
There was a problem hiding this comment.
Should we self.raise_error(...) here? Otherwise, we'll now silently continue on
There was a problem hiding this comment.
No, this is intentional. See previous threads & Slack.
Comment on lines
+5317
to
+5321
| if self.dialect.SUPPORTS_USER_DEFINED_TYPES: | ||
| this = self._parse_user_defined_type(identifier) | ||
| else: | ||
| self._retreat(self._index - 1) | ||
| return None |
There was a problem hiding this comment.
[Nit] Could we revert the if/elif/else chain to reduce some of the indentation?
Comment on lines
+808
to
+809
| self.validate_identity('1::"int"', "CAST(1 AS INT)") | ||
| assert parse_one('1::"int"', read="postgres").to.is_type(exp.DataType.Type.INT) |
There was a problem hiding this comment.
We don't need the generic parse_one here if we read into the same dialect as in the testing file.
We can grab the AST as ast = self.validate_identity(...) or do ast = self.parse_one(...) which will set the appropriate dialect.
Comment on lines
+703
to
+704
| self.validate_identity('1::"int"', "CAST(1 AS INTEGER)") | ||
| assert parse_one('1::"int"', read="redshift").to.is_type(exp.DataType.Type.INT) |
|
Merging this as is, will clean up tests afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a cast to a built-in data type, where the type is quoted:
1::"integer"We currently parse this into the correct underlying type for dialects that allow this AND support user-defined types (like tsql).
This PR allows us to parse correctly for dialects that do not support user-defined types (like redshift).