feat: Add toggle to disable default route creation for public route tables #1188
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…route feat: Add toggle to disable public default route
…route Make default opposite to match existing vars
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Please do not close. Can we have some action on this? or a decission if this is going to be merged or you would merge #1190 ? |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Please do not close |
|
this would solve #1187 |
|
I'll take a look at the Network Firewall integration options today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes introduces a variable public_enable_default_route so a default route for public subnets is not created when set to false . This enables the user to create its own default route to other gateways than Internet Gateway (IGW)
Motivation and Context
It fixes the problem of not being able to use ex. Network Firewall and enables the use case where users will need to change default route to something else than the IGW
How Has This Been Tested?
I have tested my changes from a module using the VPC. Setting the public_enable_default_route flag to false -> default route is not created for public subnet route tables
removing the public_enable_default_route flag from the settings passed to the module -> The default route to IGW is created for each public subnet route table
pre-commit run -aon my pull request