-
Notifications
You must be signed in to change notification settings - Fork 501
[immutable-arraybuffer] ArrayBuffer.prototype.sliceToImmutable #4553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gibson042
wants to merge
1
commit into
tc39:main
Choose a base branch
from
gibson042:2025-07-immutable-arraybuffer-slicetoimmutable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
369 changes: 369 additions & 0 deletions
369
test/built-ins/ArrayBuffer/prototype/sliceToImmutable/argument-coercion.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,369 @@ | ||
// Copyright (C) 2025 Richard Gibson. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
|
||
/*--- | ||
esid: sec-arraybuffer.prototype.slicetoimmutable | ||
description: > | ||
Requested start and end are coerced to integers and checked for validity, then | ||
(if valid) an immutable ArrayBuffer with the correct length and contents is | ||
returned | ||
info: | | ||
ArrayBuffer.prototype.sliceToImmutable ( start, end ) | ||
... | ||
5. Let len be O.[[ArrayBufferByteLength]]. | ||
6. Let bounds be ? ResolveBounds(len, start, end). | ||
7. Let first be bounds.[[From]]. | ||
8. Let final be bounds.[[To]]. | ||
9. Let newLen be max(final - first, 0). | ||
... | ||
12. Let fromBuf be O.[[ArrayBufferData]]. | ||
13. Let currentLen be O.[[ArrayBufferByteLength]]. | ||
14. If currentLen < final, throw a RangeError exception. | ||
15. Let newBuffer be ? AllocateImmutableArrayBuffer(%ArrayBuffer%, newLen, fromBuf, first, newLen). | ||
16. Return newBuffer. | ||
|
||
ResolveBounds ( len, start, end ) | ||
1. Let relativeStart be ? ToIntegerOrInfinity(start). | ||
2. If relativeStart = -∞, let from be 0. | ||
3. Else if relativeStart < 0, let from be max(len + relativeStart, 0). | ||
4. Else, let from be min(relativeStart, len). | ||
5. If end is undefined, let relativeEnd be len; else let relativeEnd be ? ToIntegerOrInfinity(end). | ||
6. If relativeEnd = -∞, let to be 0. | ||
7. Else if relativeEnd < 0, let to be max(len + relativeEnd, 0). | ||
8. Else, let to be min(relativeEnd, len). | ||
9. Return the Record { [[From]]: from, [[To]]: to }. | ||
|
||
ToIntegerOrInfinity ( argument ) | ||
1. Let number be ? ToNumber(argument). | ||
2. If number is one of NaN, +0𝔽, or -0𝔽, return 0. | ||
3. If number is +∞𝔽, return +∞. | ||
4. If number is -∞𝔽, return -∞. | ||
5. Return truncate(ℝ(number)). | ||
features: [immutable-arraybuffer] | ||
includes: [compareArray.js] | ||
---*/ | ||
|
||
var ab = new ArrayBuffer(8); | ||
assert.sameValue(ab.sliceToImmutable().byteLength, 8, | ||
"Must default to receiver byteLength."); | ||
ab = new ArrayBuffer(8); | ||
assert.sameValue(ab.sliceToImmutable(undefined, undefined).byteLength, 8, | ||
"Must default (undefined, undefined) to receiver byteLength."); | ||
|
||
function repr(value) { | ||
if (typeof value === "string") return JSON.stringify(value); | ||
if (typeof value === "bigint") return String(value) + "n"; | ||
if (!value && 1/value === -Infinity) return "-0"; | ||
return String(value); | ||
} | ||
|
||
var make32ByteArrayBuffer() { | ||
var ab = new ArrayBuffer(32); | ||
var view = new Uint8Array(ab); | ||
for (var i = 0; i < 8; i++) view[i] = i + 1; | ||
return ab; | ||
} | ||
|
||
var goodInputs = [ | ||
// Unmodified non-negative integral numbers | ||
[0, 0], | ||
[1, 1], | ||
[10, 10], | ||
// Truncated non-negative integral numbers | ||
[0.9, 0], | ||
[1.9, 1], | ||
[-0.9, 0], | ||
// Negative integral numbers | ||
[-1, -1], | ||
[-1.9, -1], | ||
[-2.9, -2], | ||
// Coerced to integral numbers | ||
[-0, 0], | ||
[null, 0], | ||
[false, 0], | ||
[true, 1], | ||
["", 0], | ||
["8", 8], | ||
["+9", 9], | ||
["-9", -9], | ||
["10e0", 10], | ||
["+1.1E+1", 11], | ||
["+.12e2", 12], | ||
["130e-1", 13], | ||
["0b1110", 14], | ||
["0XF", 15], | ||
["0xf", 15], | ||
["0o20", 16], | ||
// Coerced to NaN and mapped to 0 | ||
[NaN, 0], | ||
["7up", 0], | ||
["1_0", 0], | ||
["0x00_ff", 0], | ||
// Clamped | ||
[-32, 0], | ||
["-32", 0], | ||
[-Infinity, 0], | ||
["-Infinity", 0], | ||
[33, 32], | ||
["33", 32], | ||
[Infinity, 32], | ||
["Infinity", 32] | ||
]; | ||
|
||
for (var i = 0; i < goodInputs.length; i++) { | ||
var rawStart = goodInputs[i][0]; | ||
var intStart = goodInputs[i][1]; | ||
for (var j = 0; j < goodInputs.length; j++) { | ||
var rawEnd = goodInputs[j][0]; | ||
var intEnd = goodInputs[j][1]; | ||
var intLength = intEnd - intStart; | ||
var source = make32ByteArrayBuffer(); | ||
var expectContents = Array.from(new Uint8Array(source)).slice(rawStart, rawEnd); | ||
var dest = source.sliceToImmutable(rawStart, rawEnd); | ||
assert.sameValue(dest.byteLength, intLength, | ||
"sliceToImmutable(" + repr(rawStart) + ", " + repr(rawEnd) + ")"); | ||
assert.compareArray(new Uint8Array(dest), expectContents, | ||
"sliceToImmutable(" + repr(rawStart) + ", " + repr(rawEnd) + ")"); | ||
assert.sameValue(dest.immutable, true, | ||
"sliceToImmutable(" + repr(rawStart) + ", " + repr(rawEnd) + ")"); | ||
} | ||
} | ||
|
||
var whitespace = "\t\v\f\uFEFF\u3000\n\r\u2028\u2029"; | ||
function pad(rawInput) { | ||
if (typeof rawInput === "string") { | ||
return { skip: false, string: whitespace + rawInput + whitespace }; | ||
} else if (typeof rawInput === "number") { | ||
return { skip: false, string: whitespace + repr(rawInput) + whitespace }; | ||
} | ||
return { skip: true }; | ||
} | ||
for (var i = 0; i < goodInputs.length; i++) { | ||
var rawStart = goodInputs[i][0]; | ||
var intStart = goodInputs[i][1]; | ||
var paddedStart = pad(rawStart); | ||
if (paddedStart.skip) continue; | ||
for (var j = 0; j < goodInputs.length; j++) { | ||
var rawEnd = goodInputs[j][0]; | ||
var intEnd = goodInputs[j][1]; | ||
var paddedEnd = pad(rawEnd); | ||
if (paddedEnd.skip) continue; | ||
var intLength = intEnd - intStart; | ||
var source = make32ByteArrayBuffer(); | ||
var expectContents = Array.from(new Uint8Array(source)).slice(rawStart, rawEnd); | ||
var dest = source.sliceToImmutable(paddedStart.string, paddedEnd.string); | ||
assert.sameValue(dest.byteLength, intLength, | ||
"sliceToImmutable(" + repr(paddedStart.string) + ", " + repr(paddedEnd.string) + ")"); | ||
assert.compareArray(new Uint8Array(dest), expectContents, | ||
"sliceToImmutable(" + repr(paddedStart.string) + ", " + repr(paddedEnd.string) + ")"); | ||
assert.sameValue(dest.immutable, true, | ||
"sliceToImmutable(" + repr(paddedStart.string) + ", " + repr(paddedEnd.string) + ")"); | ||
} | ||
} | ||
|
||
for (var i = 0; i < goodInputs.length; i++) { | ||
var rawStart = goodInputs[i][0]; | ||
var intStart = goodInputs[i][1]; | ||
for (var j = 0; j < goodInputs.length; j++) { | ||
var rawEnd = goodInputs[j][0]; | ||
var intEnd = goodInputs[j][1]; | ||
var intLength = intEnd - intStart; | ||
|
||
var calls = []; | ||
|
||
var badStartValueOf = false; | ||
var badStartToString = false; | ||
var objStart = { | ||
valueOf() { | ||
calls.push("start.valueOf"); | ||
return badStartValueOf ? {} : rawStart; | ||
}, | ||
toString() { | ||
calls.push("start.toString"); | ||
return badStartToString ? {} : rawStart; | ||
} | ||
}; | ||
var badEndValueOf = false; | ||
var badEndToString = false; | ||
var objEnd = { | ||
valueOf() { | ||
calls.push("end.valueOf"); | ||
return badEndValueOf ? {} : rawEnd; | ||
}, | ||
toString() { | ||
calls.push("end.toString"); | ||
return badEndToString ? {} : rawEnd; | ||
} | ||
}; | ||
function reprArgs(startMethodName, endMethodName) { | ||
var startRepr = "{ " + startMethodName + ": () => " + repr(rawStart) + " }"; | ||
var endRepr = "{ " + endMethodName + ": () => " + repr(rawEnd) + " }"; | ||
return "(" + startRepr + ", " + endRepr + ")"; | ||
} | ||
|
||
var source = make32ByteArrayBuffer(); | ||
var expectContents = Array.from(new Uint8Array(source)).slice(rawStart, rawEnd); | ||
var dest = source.sliceToImmutable(objStart, objEnd); | ||
assert.sameValue(dest.byteLength, intLength, | ||
"sliceToImmutable" + reprArgs("valueOf", "valueOf")); | ||
assert.compareArray(new Uint8Array(dest), expectContents, | ||
"sliceToImmutable" + reprArgs("valueOf", "valueOf")); | ||
assert.sameValue(dest.immutable, true, | ||
"sliceToImmutable" + reprArgs("valueOf", "valueOf")); | ||
assert.compareArray(calls, ["start.valueOf", "end.valueOf"], | ||
"sliceToImmutable" + reprArgs("valueOf", "valueOf")); | ||
|
||
badStartValueOf = true; | ||
calls = []; | ||
source = make32ByteArrayBuffer(); | ||
dest = source.sliceToImmutable(objStart, objEnd); | ||
assert.sameValue(dest.byteLength, intLength, | ||
"sliceToImmutable" + reprArgs("toString", "valueOf")); | ||
assert.compareArray(new Uint8Array(dest), expectContents, | ||
"sliceToImmutable" + reprArgs("toString", "valueOf")); | ||
assert.sameValue(dest.immutable, true, | ||
"sliceToImmutable" + reprArgs("toString", "valueOf")); | ||
assert.compareArray(calls, ["start.valueOf", "start.toString", "end.valueOf"], | ||
"sliceToImmutable" + reprArgs("toString", "valueOf")); | ||
|
||
badEndValueOf = true; | ||
calls = []; | ||
source = make32ByteArrayBuffer(); | ||
dest = source.sliceToImmutable(objStart, objEnd); | ||
assert.sameValue(dest.byteLength, intLength, | ||
"sliceToImmutable" + reprArgs("toString", "toString")); | ||
assert.compareArray(new Uint8Array(dest), expectContents, | ||
"sliceToImmutable" + reprArgs("toString", "toString")); | ||
assert.sameValue(dest.immutable, true, | ||
"sliceToImmutable" + reprArgs("toString", "toString")); | ||
assert.compareArray(calls, ["start.valueOf", "start.toString", "end.valueOf", "end.toString"], | ||
"sliceToImmutable" + reprArgs("toString", "toString")); | ||
|
||
badEndToString = true; | ||
if (typeof Symbol === undefined || !Symbol.toPrimitive) continue; | ||
calls = []; | ||
objEnd[Symbol.toPrimitive] = function(hint) { | ||
calls.push("end[Symbol.toPrimitive](" + hint + ")"); | ||
return rawEnd; | ||
}; | ||
source = make32ByteArrayBuffer(); | ||
dest = source.sliceToImmutable(objStart, objEnd); | ||
assert.sameValue(dest.byteLength, intLength, | ||
"sliceToImmutable" + reprArgs("toString", "[Symbol.toPrimitive]")); | ||
assert.compareArray(new Uint8Array(dest), expectContents, | ||
"sliceToImmutable" + reprArgs("toString", "[Symbol.toPrimitive]")); | ||
assert.sameValue(dest.immutable, true, | ||
"sliceToImmutable" + reprArgs("toString", "[Symbol.toPrimitive]")); | ||
assert.compareArray( | ||
calls, | ||
["start.valueOf", "start.toString", "end[Symbol.toPrimitive](number)"], | ||
"sliceToImmutable" + reprArgs("toString", "[Symbol.toPrimitive]") | ||
); | ||
|
||
badStartToString = true; | ||
calls = []; | ||
objStart[Symbol.toPrimitive] = function(hint) { | ||
calls.push("start[Symbol.toPrimitive](" + hint + ")"); | ||
return rawStart; | ||
}; | ||
source = make32ByteArrayBuffer(); | ||
dest = source.sliceToImmutable(objStart, objEnd); | ||
assert.sameValue(dest.byteLength, intLength, | ||
"sliceToImmutable" + reprArgs("[Symbol.toPrimitive]", "[Symbol.toPrimitive]")); | ||
assert.compareArray(new Uint8Array(dest), expectContents, | ||
"sliceToImmutable" + reprArgs("[Symbol.toPrimitive]", "[Symbol.toPrimitive]")); | ||
assert.sameValue(dest.immutable, true, | ||
"sliceToImmutable" + reprArgs("[Symbol.toPrimitive]", "[Symbol.toPrimitive]")); | ||
assert.compareArray( | ||
calls, | ||
["start[Symbol.toPrimitive](number)", "end[Symbol.toPrimitive](number)"], | ||
"sliceToImmutable" + reprArgs("[Symbol.toPrimitive]", "[Symbol.toPrimitive]")); | ||
); | ||
} | ||
} | ||
|
||
var badInputs = [ | ||
// Out of range numbers | ||
[-1, RangeError], | ||
[9007199254740992, RangeError], // Math.pow(2, 53) = 9007199254740992 | ||
[Infinity, RangeError], | ||
[-Infinity, RangeError], | ||
// non-numbers | ||
typeof Symbol === undefined ? undefined : [Symbol("1"), TypeError], | ||
typeof Symbol === undefined || !Symbol.for ? undefined : [Symbol.for("1"), TypeError], | ||
typeof BigInt === undefined ? undefined : [BigInt(1), TypeError], | ||
]; | ||
|
||
for (var i = 0; i < badInputs.length; i++) { | ||
if (!badInputs[i]) continue; | ||
var rawBad = badInputs[i][0]; | ||
var expectedErr = badInputs[i][1]; | ||
|
||
var ab = make32ByteArrayBuffer(); | ||
var rawGood = goodInputs[i % goodInputs.length][0]; | ||
var calls = []; | ||
var objGood = { | ||
valueOf() { | ||
calls.push("good.valueOf"); | ||
return rawGood; | ||
} | ||
}; | ||
assert.throws(expectedErr, function() { | ||
ab.sliceToImmutable(rawBad, objGood); | ||
}, "sliceToImmutable(" + repr(rawBad) + ", { valueOf: () => " + repr(rawGood) + " })"); | ||
assert.compareArray(calls, [], | ||
"sliceToImmutable(" + repr(rawBad) + ", { valueOf: () => " + repr(rawGood) + " })"); | ||
); | ||
|
||
calls = []; | ||
assert.throws(expectedErr, function() { | ||
ab.sliceToImmutable(objGood, rawBad); | ||
}, "sliceToImmutable({ valueOf: () => " + repr(rawGood) + " }, " + repr(rawBad) + ")"); | ||
assert.compareArray(calls, ["good.valueOf"], | ||
"sliceToImmutable({ valueOf: () => " + repr(rawGood) + " }, " + repr(rawBad) + ")"); | ||
); | ||
} | ||
|
||
for (var i = 0; i < badInputs.length; i++) { | ||
if (!badInputs[i]) continue; | ||
var rawBad = badInputs[i][0]; | ||
var expectedErr = badInputs[i][1]; | ||
if (typeof rawBad !== "number") continue; | ||
rawBad = repr(rawBad); | ||
var paddedBad = whitespace + rawBad + whitespace; | ||
var ab = make32ByteArrayBuffer(); | ||
assert.throws(expectedErr, function() { | ||
ab.sliceToImmutable(paddedBad); | ||
}, "sliceToImmutable(" + repr(paddedBad) + ")"); | ||
} | ||
|
||
var calls = []; | ||
var objBad = { | ||
toString() { | ||
calls.push("toString"); | ||
return {}; | ||
}, | ||
valueOf() { | ||
calls.push("valueOf"); | ||
return {}; | ||
} | ||
}; | ||
ab = make32ByteArrayBuffer(); | ||
assert.throws(TypeError, function() { | ||
ab.sliceToImmutable(objBad); | ||
}, "sliceToImmutable(badOrdinaryToPrimitive)"); | ||
assert.compareArray(calls, ["valueOf", "toString"], | ||
"sliceToImmutable(badOrdinaryToPrimitive)"); | ||
if (typeof Symbol !== undefined && Symbol.toPrimitive) { | ||
calls = []; | ||
objBad[Symbol.toPrimitive] = function(hint) { | ||
calls.push("Symbol.toPrimitive(" + hint + ")"); | ||
return {}; | ||
}; | ||
ab = make32ByteArrayBuffer(); | ||
assert.throws(TypeError, function() { | ||
ab.sliceToImmutable(objBad); | ||
}, "sliceToImmutable(badExoticToPrimitive)"); | ||
assert.compareArray(calls, ["Symbol.toPrimitive(number)"], | ||
"sliceToImmutable(badExoticToPrimitive)"); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion, add something to these assertion messages to distinguish which assertion is failing (byte length, contents, or immutability) (Same for below)