Add tests for WebKit Bug 242740: simultaneous imports with top-level await #4544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…await - Add simultaneous-imports-race-condition.js to test that simultaneous imports wait for top-level await completion - Add simultaneous-imports-reference-error.js to test that no ReferenceError is thrown during simultaneous imports - Both tests will fail in WebKit-based browsers due to the bug - Tests follow test262 style and reproduce the race condition described in the bug report Bug: https://bugs.webkit.org/show_bug.cgi?id=242740
…ait modules Add two test cases to reproduce WebKit Bug 242740 where simultaneous dynamic imports of a module with top-level await can cause ReferenceError or race conditions. - simultaneous-imports-race-condition.js: Tests that all simultaneous imports wait for module evaluation to complete - simultaneous-imports-reference-error.js: Tests that no ReferenceError is thrown during simultaneous imports Both tests use the standard test262 pattern with top-level await and () for completion.
Remove redundant reference-error test, keeping only the race-condition test which covers the core issue. This provides a cleaner, more focused PR that clearly exposes the WebKit bug with minimal scope.
|
Is this behaviour already covered by https://github.com/tc39/test262/blob/main/test/language/module-code/top-level-await/dynamic-import-of-waiting-module.js? Maybe just add the namespace check to that test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for WebKit Bug 242740: simultaneous imports with top-level await
Summary
Adds test cases that reproduce WebKit Bug 242740, where simultaneous imports of a module with top-level await can fail with ReferenceError or resolve prematurely.
Bug Reference
Tests Added
simultaneous-imports-race-condition.js- Tests that simultaneous imports wait for top-level await completionsimultaneous-imports-reference-error.js- Tests that no ReferenceError is thrown during simultaneous importsExpected Behavior
Affected Browsers