Metrics: vend counters as strings to avoid making SWBProtocol part of the public interface for SwiftBuild #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirza-garibovic
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci test |
owenv
approved these changes
Sep 15, 2025
Sources/SwiftBuild/ConsoleCommands/SWBServiceConsoleBuildCommandProtocol.swift
Outdated
Show resolved
Hide resolved
mirza-garibovic
force-pushed
the
push-osoklwzntwnu
branch
from
2bf3234 to
d544a5a
Compare
|
Going to wait for @akyrtzi review for this one. |
neonichu
approved these changes
Sep 16, 2025
jakepetroules
approved these changes
Sep 16, 2025
akyrtzi
reviewed
Sep 16, 2025
mirza-garibovic
force-pushed
the
push-osoklwzntwnu
branch
from
d544a5a to
c8b3c74
Compare
akyrtzi
approved these changes
Sep 18, 2025
|
@swift-ci test |
… the public interface for SwiftBuild
mirza-garibovic
force-pushed
the
push-osoklwzntwnu
branch
from
c8b3c74 to
b78d25a
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.