Add request to get preferred run destination for a platform #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
preferred-run-destination
branch
2 times, most recently
from
2543368 to
64da735
Compare
ahoppen
changed the title
ahoppen
force-pushed
the
preferred-run-destination
branch
from
64da735 to
c1e0629
Compare
ahoppen
requested review from
aciidgh,
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
owenv
approved these changes
Aug 30, 2025
That’s the idea. Do you think this needs to be clarified somewhere in a doc comment or is it clean enough from the current ones? |
ahoppen
force-pushed
the
preferred-run-destination
branch
from
c1e0629 to
17b6273
Compare
|
Added a few test cases as well based on Owen’s comment here: #761. Would be good to get a review for those as well. |
|
@swift-ci Please test |
neonichu
approved these changes
Sep 2, 2025
|
@swift-ci test |
jakepetroules
requested changes
Sep 2, 2025
ahoppen
force-pushed
the
preferred-run-destination
branch
from
17b6273 to
87a881d
Compare
This can be useful when implementing a system that needs to configure the active run destination of a build request but only knows the platform that the user is requesting a build for, but no architecture etc.
ahoppen
force-pushed
the
preferred-run-destination
branch
from
87a881d to
461ae49
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful when implementing a system that needs to configure the active run destination of a build request but only knows the platform that the user is requesting a build for, but no architecture etc.