Skip to content

Conversation

ntombing
Copy link
Contributor

@ntombing ntombing commented Sep 9, 2025

No description provided.

Copy link

linear bot commented Sep 9, 2025

Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for incomparable-tiramisu-91a96a ready!

Name Link
🔨 Latest commit 0e867f3
🔍 Latest deploy log https://app.netlify.com/projects/incomparable-tiramisu-91a96a/deploys/68c83164a4f859000817f86f
😎 Deploy Preview https://deploy-preview-412--incomparable-tiramisu-91a96a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ntombing ntombing marked this pull request as ready for review September 10, 2025 15:42
Copy link
Contributor

@max-koro max-koro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Made a tiny edit to the phone number obfuscation in figma but nothing noticeable, new flows look great.

Left a couple comments on the docs code below, just suggestions for phrasing improvements and other minor tidbits. Well done!

@@ -42,24 +42,32 @@ Your user:
1. **Confirms their phone number**, after which they continue the sign-up process on their mobile device. How they confirm this step depends on whether they opened the sign-up link from a computer or their mobile device:
1. **Computer**: Swan sends your user a text message with a link to open on their mobile device.
1. **Mobile device**: Swan sends your user a text message with a verification code.
1. **Enters their personal information**: first name, last name, and birthdate. This information must match the information that appears on their identity documents.
1. (If needed) **Enters their personal information**: first name, last name, and birthdate. This information must match the information that appears on their identity documents.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. (If needed) **Enters their personal information**: first name, last name, and birthdate. This information must match the information that appears on their identity documents.
1. **Enters their personal information**: first name, last name, and birthdate. This information must match the information that appears on their identity documents.
- Skip this step if you included this information when creating their sign-up link.

Did I get this right? Not a fan of (If Needed) Do this

Copy link
Contributor Author

@ntombing ntombing Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. We're talking about the user's experience here, so I specified that the user skips this step (if the partner included it). Thanks for the suggestion.

I also kept the link to the "Optional parameters" when creating a URL.

ntombing and others added 3 commits September 15, 2025 17:00
Co-authored-by: Max B. <17831738+max-koro@users.noreply.github.com>
Co-authored-by: Max B. <17831738+max-koro@users.noreply.github.com>
Co-authored-by: Max B. <17831738+max-koro@users.noreply.github.com>
@ntombing ntombing removed the request for review from racene-swan September 15, 2025 15:03
@ntombing ntombing requested a review from max-koro September 15, 2025 15:32
Copy link
Contributor

@max-koro max-koro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ntombing ntombing merged commit 143f845 into main Sep 15, 2025
4 checks passed
@ntombing ntombing deleted the DOC-1027/user-sign-up-flow branch September 15, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants