-
Notifications
You must be signed in to change notification settings - Fork 10
Adding sign-up flow diagram to docs #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for incomparable-tiramisu-91a96a ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Made a tiny edit to the phone number obfuscation in figma but nothing noticeable, new flows look great.
Left a couple comments on the docs code below, just suggestions for phrasing improvements and other minor tidbits. Well done!
docs/topics/users/index.mdx
Outdated
@@ -42,24 +42,32 @@ Your user: | |||
1. **Confirms their phone number**, after which they continue the sign-up process on their mobile device. How they confirm this step depends on whether they opened the sign-up link from a computer or their mobile device: | |||
1. **Computer**: Swan sends your user a text message with a link to open on their mobile device. | |||
1. **Mobile device**: Swan sends your user a text message with a verification code. | |||
1. **Enters their personal information**: first name, last name, and birthdate. This information must match the information that appears on their identity documents. | |||
1. (If needed) **Enters their personal information**: first name, last name, and birthdate. This information must match the information that appears on their identity documents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. (If needed) **Enters their personal information**: first name, last name, and birthdate. This information must match the information that appears on their identity documents. | |
1. **Enters their personal information**: first name, last name, and birthdate. This information must match the information that appears on their identity documents. | |
- Skip this step if you included this information when creating their sign-up link. |
Did I get this right? Not a fan of (If Needed) Do this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. We're talking about the user's experience here, so I specified that the user skips this step (if the partner included it). Thanks for the suggestion.
I also kept the link to the "Optional parameters" when creating a URL.
Co-authored-by: Max B. <17831738+max-koro@users.noreply.github.com>
Co-authored-by: Max B. <17831738+max-koro@users.noreply.github.com>
Co-authored-by: Max B. <17831738+max-koro@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.