✨(frontend) Comments ! #1330
Draft
✨(frontend) Comments ! #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feat/comments-frontend
branch
4 times, most recently
from
c8c08b8 to
1d7a236
Compare
To allow a user to comment a document we added a new role: commentator. Commentator is higher than reader but lower than editor.
In order to store the comments on a document, we created a new model Comment. User is nullable because anonymous users can comment a Document is this one is public with a link_role commentator.
This commit add the CRUD part to manage comment lifeycle. Permissions are relying on the Document and Comment abilities. Comment viewset depends on the Document route and is added to the document_related_router. Dedicated serializer and permission are created.
Implemented the comments feature for the document editor. We are now able to add, view, and manage comments within the document editor interface.
We extracted the UserAvatar component from the doc-share feature and integrated it into the users feature. It will be used in the thread comments feature as well.
A circular dependency was introduced in the previous commit. This commit resolves the circular dependency by refactoring the code to remove the circular reference.
Replace the default comment toolbar button with a custom one to follow the design system.
Our document got new types: - user can be commenters, commenters can view and add comments to documents but cannot edit the document content itself. - document can be in 'commenters' mode, allowing viewers to add comments.
AntoLC
force-pushed
the
feat/comments-frontend
branch
from
1d7a236 to
fe926fc
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implementation of the comment feature frontend side.