Skip to content

Conversation

amirejaz
Copy link
Contributor

@amirejaz amirejaz commented Sep 3, 2025

No description provided.

@amirejaz amirejaz changed the title Support remote server through APIs Support running and managing remote server through APIs Sep 3, 2025
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 42.36111% with 166 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.93%. Comparing base (28001e4) to head (07190bc).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/api/v1/workload_service.go 34.19% 101 Missing and 1 partial ⚠️
pkg/api/server.go 0.00% 30 Missing ⚠️
pkg/api/v1/secrets.go 0.00% 17 Missing ⚠️
pkg/api/v1/workloads.go 0.00% 16 Missing ⚠️
pkg/runner/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1693      +/-   ##
==========================================
+ Coverage   39.43%   39.93%   +0.49%     
==========================================
  Files         177      179       +2     
  Lines       20777    20853      +76     
==========================================
+ Hits         8193     8327     +134     
+ Misses      11979    11914      -65     
- Partials      605      612       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Collaborator

coveralls commented Sep 3, 2025

Coverage Status

coverage: 37.249% (+0.4%) from 36.847%
when pulling 07190bc on remote-server-apis
into 28001e4 on main.

@amirejaz amirejaz requested a review from dmjb September 5, 2025 10:15
Copy link
Contributor

@yrobla yrobla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one concern i have, but not related to this pr, is if we are validating the urls... proper schema, no injection, etc... but this is a general problem, not from this specific code

@amirejaz amirejaz merged commit a384737 into main Sep 5, 2025
31 of 32 checks passed
@amirejaz amirejaz deleted the remote-server-apis branch September 5, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants