-
Notifications
You must be signed in to change notification settings - Fork 115
adds proposal for toolhive k8s deployment architecture #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Initial thoughts. This makes a lot of sense to me @ChrisJBurns. The operator should indeed be taking responsibility for both the deployment and statefulset creation, and then also their association with various kubernetes services and other resources such that their reconciliation and reclamation can happen cleanly. I also like the idea of having the proxy still being able to request an mcp server replica + or - depending on the load it is experiencing, and while the operator has the big picture the proxy will have the data to determine the need most directly. |
Thanks for updating the architecture and making it more coherent with standard k8s deployments @ChrisJBurns. |
great work thanks @ChrisJBurns |
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1497 +/- ##
==========================================
- Coverage 42.04% 42.01% -0.04%
==========================================
Files 184 184
Lines 21649 21649
==========================================
- Hits 9103 9096 -7
- Misses 11858 11864 +6
- Partials 688 689 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm can't wait to see this architecture in action 👍
Wanted to get some early thoughts on this.
@ChrisJBurns to refine technical details if needed