Skip to content

Conversation

JesseObrien
Copy link
Contributor

When this PR merges: #1332

I'd like to rebase on top of mine to include further changes to the documentation and tests.

@eleftherias
Copy link
Member

Thanks @JesseObrien, I'll take a look at this after we get #1332 merged.

@eleftherias
Copy link
Member

Hey @JesseObrien, the Colima PR is merged, you're welcome to make your changes on top of main.

@eleftherias eleftherias mentioned this pull request Sep 8, 2025
5 tasks
@JesseObrien JesseObrien force-pushed the jesseo.colima-runtime-support branch 2 times, most recently from 6e0c546 to 0ee705d Compare September 8, 2025 19:44
@JesseObrien JesseObrien changed the title Adding Colima Runtime Support Colima Runtime Documentation Update Sep 8, 2025
@JesseObrien
Copy link
Contributor Author

@eleftherias rebased and updated the documentation.

Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.14%. Comparing base (c704a07) to head (8eb1719).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1492      +/-   ##
==========================================
+ Coverage   40.73%   42.14%   +1.40%     
==========================================
  Files         184      184              
  Lines       21425    21649     +224     
==========================================
+ Hits         8727     9123     +396     
+ Misses      12031    11836     -195     
- Partials      667      690      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Collaborator

coveralls commented Sep 9, 2025

Coverage Status

coverage: 39.123% (+0.07%) from 39.05%
when pulling 8eb1719 on JesseObrien:jesseo.colima-runtime-support
into 2169e36 on stacklok:main.

Copy link
Member

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JesseObrien, could you just run task docs to update the cli docs? Then it's ready to merge.

@JesseObrien JesseObrien force-pushed the jesseo.colima-runtime-support branch from 0ee705d to 8eb1719 Compare September 9, 2025 20:03
@eleftherias eleftherias merged commit 91ac739 into stacklok:main Sep 10, 2025
27 of 28 checks passed
@JesseObrien JesseObrien deleted the jesseo.colima-runtime-support branch September 10, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants