-
Notifications
You must be signed in to change notification settings - Fork 165
[RORDEV-1481] New audit serializers, including fully configurable serializer #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoworko
commented
Jul 25, 2025
audit/src/main/scala/tech/beshu/ror/audit/instances/BaseAuditLogSerializer.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/instances/DefaultAuditLogSerializerV1.scala
Outdated
Show resolved
Hide resolved
integration-tests/src/test/resources/ror_audit/enabled_auditing_tools/readonlyrest.yml
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
coutoPL
requested changes
Aug 11, 2025
audit/src/main/scala/tech/beshu/ror/audit/AuditFieldValue.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/BaseAuditLogSerializer.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/BaseAuditLogSerializer.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/BaseAuditLogSerializer.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/instances/DefaultAuditLogSerializerV1.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/instances/ReportingAllEventsAuditLogSerializer.scala
Outdated
Show resolved
Hide resolved
...ain/scala/tech/beshu/ror/audit/instances/ReportingAllEventsWithQueryAuditLogSerializer.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/factory/decoders/AuditingSettingsDecoder.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/factory/decoders/AuditingSettingsDecoder.scala
Outdated
Show resolved
Hide resolved
coutoPL
requested changes
Sep 1, 2025
audit/src/main/scala/tech/beshu/ror/audit/instances/FullAuditLogSerializer.scala
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/instances/FullAuditLogSerializer.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/instances/FullAuditLogWithQuerySerializer.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/utils/AuditSerializationHelper.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/AuditFieldValue.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/AuditSerializationHelper.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/factory/decoders/AuditingSettingsDecoder.scala
Show resolved
Hide resolved
core/src/main/scala/tech/beshu/ror/accesscontrol/factory/decoders/AuditingSettingsDecoder.scala
Outdated
Show resolved
Hide resolved
coutoPL
requested changes
Sep 13, 2025
audit/src/main/scala/tech/beshu/ror/audit/instances/DefaultAuditLogSerializer.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/instances/DefaultAuditLogSerializer.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/instances/DefaultAuditLogSerializerV1.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/instances/DefaultAuditLogSerializerV1.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/instances/BaseAuditLogSerializer.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/instances/DefaultAuditLogSerializer.scala
Outdated
Show resolved
Hide resolved
audit/src/main/scala/tech/beshu/ror/audit/instances/FullAuditLogWithQuerySerializer.scala
Outdated
Show resolved
Hide resolved
coutoPL
requested changes
Sep 14, 2025
.../src/test/scala/tech/beshu/ror/integration/suites/audit/LocalClusterAuditingToolsSuite.scala
Outdated
Show resolved
Hide resolved
.../src/test/scala/tech/beshu/ror/integration/suites/audit/LocalClusterAuditingToolsSuite.scala
Outdated
Show resolved
Hide resolved
coutoPL
approved these changes
Sep 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please don't forget about docs update.
coutoPL
approved these changes
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀New (ES) added new audit serializers - ReportingAllEventsAuditLogSerializer, ReportingAllEventsWithQueryAuditLogSerializer
🚀New (ES) There is an option to define custom audit serializer in config, without implementation
🐞Fix (ES) Restored backwards compatibility of custom audit log serializer implementations, that extend the
DefaultAuditLogSerializer
class. The custom serializers compiled against ROR 1.65 and 1.66, that useDefaultAuditLogSerializer
have to be recompiled in order to work.Summary by CodeRabbit