Skip to content

fix linux math linker flag #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 6, 2025
Merged

fix linux math linker flag #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0452dfb
Update Makefile: adjust linker flags for Linux and test target
Gioee Aug 6, 2025
5742954
fix(workflow): always run it but release only in the main branch
Gioee Aug 6, 2025
1f4a363
fix(Makefile): add math library flag to test target compilation
Gioee Aug 6, 2025
fac7677
fix(Makefile): correct order of arguments in linking and test target …
Gioee Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: release sqlite-js
on:
push:
branches:
- main

permissions:
contents: write
Expand Down Expand Up @@ -121,6 +119,7 @@ jobs:
runs-on: ubuntu-latest
name: release
needs: build
if: github.ref == 'refs/heads/main'

env:
GH_TOKEN: ${{ github.token }}
Expand Down
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ else ifeq ($(PLATFORM),isim)
CFLAGS += -arch x86_64 -arch arm64 $(SDK)
else # linux
TARGET := $(DIST_DIR)/js.so
LDFLAGS := -shared
LDFLAGS := -lm -shared
endif

# Object files
Expand All @@ -78,7 +78,7 @@ all: $(TARGET)

# Link the final target
$(TARGET): $(OBJ_FILES) $(DEF_FILE)
$(CC) $(LDFLAGS) -o $@ $^
$(CC) -o $@ $^ $(LDFLAGS)
ifeq ($(PLATFORM),windows)
# Generate import library for Windows
dlltool -D $@ -d $(DEF_FILE) -l $(DIST_DIR)/js.lib
Expand Down Expand Up @@ -131,7 +131,7 @@ endif

# Compile test target
$(TEST_TARGET): $(TEST_FILES) $(TARGET)
$(CC) $(INCLUDES) $^ -lm -o $@ libs/sqlite3.c -DSQLITE_CORE
$(CC) $(INCLUDES) $^ -o $@ libs/sqlite3.c -DSQLITE_CORE

# Testing the extension
test: $(TARGET) $(TEST_TARGET)
Expand Down
Loading