Change examples away from Haiku #1300
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lockwo
changed the title
|
Awesome! 🤩 Thank you for your PR! I'll check it this weekend 🙏 |
|
hey guys, I'm glad I found this, as I was struggling to migrate pgx-alphazero code to equinox.. @lockwo the wandb link seems to have expired. I'm curious about your go-9x9 run. Do you happen to have any details somewhere else? Thanks |
|
Oops, I think I cleaned out that WB account recently. I can see about re-running the experiments if needed. For the 9x9 go, there just so happens to be a screenshot of the results in the old equinox PR (patrick-kidger/equinox#948, just look at the batch norm that worked lol since that's the one in use now). Code wise, it's the exact same as in the PR (no special sauce beyond that) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit later than I meant to, but this addresses #1059. Pretty straightforward change to equinox style NNs. Some minor speed differences that could be optimized (see patrick-kidger/equinox#928, patrick-kidger/equinox#926), but IMO it's fast enough. This PR also depends on the following PR to equinox to update its batch norm code to be more standard with other jax libraries: patrick-kidger/equinox#948.
Full report comparison haiku and equinox should be available here (note, the results for Haiku were just done on
main, also for minatar I used 1xA100 and for AZ I used 4xA100): https://api.wandb.ai/links/rl-exps/fak1nv1n