This repository was archived by the owner on Mar 2, 2021. It is now read-only.
Fixing SecureConnectionStart bigger than zero condition #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While conducting pageview performance analysis on our webpages, we noticed that several pageviews events carried many null values in their information. Further investigating, we came across the condition
in the timing context table calculations requiring secure_connection_start to be bigger than 0.
Apparently, on a user first access to a page the performanceTiming event carries a value for secure_connection_start timing, but on later access this value is set to 0. As a consequence we had approximately only 50% of pageview events with load performance information.
Removing the condition of the value being bigger than 0 should fix this problem.