Skip to content

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Sep 4, 2025

revival of #144679

currently always considering PhantomData moveable, let's hope that's enough for cargo to build 💀

r? @yoshuawuyts

@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

Failed to set assignee to yoshuawuyts: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 4, 2025
@lcnr lcnr changed the title rarw xd [DO NOT MERGE] rarw xd Sep 4, 2025
@lcnr lcnr changed the title [DO NOT MERGE] rarw xd [DO NOT MERGE] Move trait perf test Sep 4, 2025
@rust-log-analyzer

This comment has been minimized.

@lcnr
Copy link
Contributor Author

lcnr commented Sep 4, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 4, 2025
[DO NOT MERGE] `Move` trait perf test
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 4, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Sep 4, 2025

💔 Test for 1a0c49b failed: CI. Failed jobs:

@lcnr
Copy link
Contributor Author

lcnr commented Sep 4, 2025

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 4, 2025
[DO NOT MERGE] `Move` trait perf test
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Sep 4, 2025

💔 Test for 2413862 failed: CI. Failed jobs:

@bors
Copy link
Collaborator

bors commented Sep 11, 2025

☔ The latest upstream changes (presumably #146418) made this pull request unmergeable. Please resolve the merge conflicts.

@lcnr
Copy link
Contributor Author

lcnr commented Sep 12, 2025

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 12, 2025
[DO NOT MERGE] `Move` trait perf test
@lcnr
Copy link
Contributor Author

lcnr commented Sep 12, 2025

@bors try cancel

@rust-bors
Copy link

rust-bors bot commented Sep 12, 2025

Try build cancelled. Cancelled workflows:

@lcnr
Copy link
Contributor Author

lcnr commented Sep 12, 2025

@bors try

rust-bors bot added a commit that referenced this pull request Sep 12, 2025
[DO NOT MERGE] `Move` trait perf test
@rust-bors

This comment has been minimized.

@lcnr
Copy link
Contributor Author

lcnr commented Sep 12, 2025

@bors try cancel

@rust-bors
Copy link

rust-bors bot commented Sep 12, 2025

Try build cancelled. Cancelled workflows:

@lcnr
Copy link
Contributor Author

lcnr commented Sep 12, 2025

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 12, 2025
[DO NOT MERGE] `Move` trait perf test
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Sep 12, 2025

💔 Test for a1726fc failed: CI. Failed jobs:

@rust-log-analyzer

This comment has been minimized.

@lcnr
Copy link
Contributor Author

lcnr commented Sep 12, 2025

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 12, 2025
[DO NOT MERGE] `Move` trait perf test
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-19-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    any::dyn_type_name

test result: FAILED. 2198 passed; 1 failed; 5 ignored; 0 measured; 0 filtered out; finished in 2.82s

error: test failed, to rerun pass `-p coretests --test coretests`
env -u RUSTC_WRAPPER CARGO_ENCODED_RUSTDOCFLAGS="-Csymbol-mangling-version=v0\u{1f}-Zrandomize-layout\u{1f}-Zunstable-options\u{1f}--check-cfg=cfg(bootstrap)\u{1f}--check-cfg=cfg(llvm_enzyme)\u{1f}-Dwarnings\u{1f}-Wrustdoc::invalid_codeblock_attributes\u{1f}--crate-version\u{1f}1.91.0-nightly\t(831b9d3c6\t2025-09-12)" CARGO_ENCODED_RUSTFLAGS="-Csymbol-mangling-version=v0\u{1f}-Zrandomize-layout\u{1f}-Zunstable-options\u{1f}--check-cfg=cfg(bootstrap)\u{1f}--check-cfg=cfg(llvm_enzyme)\u{1f}-Zmacro-backtrace\u{1f}-Csplit-debuginfo=off\u{1f}-Clink-arg=-L/usr/lib/llvm-19/lib\u{1f}-Cllvm-args=-import-instr-limit=10\u{1f}-Clink-args=-Wl,-z,origin\u{1f}-Clink-args=-Wl,-rpath,$ORIGIN/../lib\u{1f}-Alinker-messages\u{1f}--cap-lints=allow\u{1f}--cfg\u{1f}randomized_layouts" RUSTC="/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-codegen/cg_clif/dist/rustc-clif" RUSTDOC="/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-codegen/cg_clif/dist/rustdoc-clif" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage0/bin/cargo" "test" "--manifest-path" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-codegen/cg_clif/build/sysroot_tests/Cargo.toml" "--target-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-codegen/cg_clif/build/sysroot_tests_target" "--locked" "--target" "aarch64-unknown-linux-gnu" "-p" "coretests" "-p" "alloctests" "--tests" "--" "-q" exited with status ExitStatus(unix_wait_status(25856))
Command `/checkout/obj/build/aarch64-unknown-linux-gnu/stage0/bin/cargo run --target aarch64-unknown-linux-gnu -Zbinary-dep-depinfo -j 4 -Zroot-dir=/checkout --locked --color always --release --manifest-path /checkout/compiler/rustc_codegen_cranelift/build_system/Cargo.toml -- test --download-dir /checkout/obj/build/cg_clif_download --out-dir /checkout/obj/build/aarch64-unknown-linux-gnu/stage2-codegen/cg_clif --no-unstable-features --use-backend cranelift --sysroot llvm --skip-test testsuite.extended_sysroot [workdir=/checkout/compiler/rustc_codegen_cranelift]` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/test.rs:3648:25
Executed at: src/bootstrap/src/core/build_steps/test.rs:3693:26

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `--stage 2 test --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest`
Build completed unsuccessfully in 0:27:40
  local time: Fri Sep 12 09:52:05 UTC 2025
  network time: Fri, 12 Sep 2025 09:52:05 GMT
##[error]Process completed with exit code 1.

@rust-bors
Copy link

rust-bors bot commented Sep 12, 2025

☀️ Try build successful (CI)
Build commit: 74073b7 (74073b774d21d91e86b8d284d93867acd900175d, parent: 8e2ed71effd5f81bff319c0c7adaca42084e2a71)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (74073b7): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
4.7% [0.2%, 42.9%] 246
Regressions ❌
(secondary)
141.1% [0.0%, 7411.5%] 249
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.4% [-0.7%, -0.2%] 2
All ❌✅ (primary) 4.7% [0.2%, 42.9%] 246

Max RSS (memory usage)

Results (primary 2.6%, secondary 315.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.6% [0.6%, 7.7%] 69
Regressions ❌
(secondary)
326.7% [1.1%, 1678.2%] 27
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) 2.6% [0.6%, 7.7%] 69

Cycles

Results (primary 7.9%, secondary 469.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
8.0% [1.3%, 35.2%] 98
Regressions ❌
(secondary)
488.9% [2.0%, 13185.4%] 121
Improvements ✅
(primary)
-3.8% [-3.8%, -3.8%] 1
Improvements ✅
(secondary)
-3.2% [-4.7%, -2.1%] 5
All ❌✅ (primary) 7.9% [-3.8%, 35.2%] 99

Binary size

Results (primary 0.4%, secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.4% [0.0%, 1.7%] 110
Regressions ❌
(secondary)
0.3% [0.0%, 1.7%] 85
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.4% [0.0%, 1.7%] 110

Bootstrap: 467.415s -> 491.318s (5.11%)
Artifact size: 387.84 MiB -> 387.53 MiB (-0.08%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 12, 2025
@lcnr lcnr closed this Sep 19, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants