Skip to content

fix(new_without_default): if new has #[cfg], copy that onto impl Default #15720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(new_without_default): if new has #[cfg], copy that onto impl Default #15720

wants to merge 2 commits into from
+154 −89

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Sep 19, 2025

Fixes #14552

changelog: [new_without_default]: if new has #[cfg], copy that onto impl Default

@ada4a
clean-up
f7f5cfc 
- reduce indentation
- use `snippet_with_applicability`
@ada4a
fix(new_without_default): if new has #[cfg], copy that onto `impl…
6a4abd0 
… Default`
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@samueltardieu samueltardieu

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-fix for new_without_default ignores conditional compilation
3 participants
@ada4a @rustbot @samueltardieu