extend while_let_loop to loop { let else }

[bend-n]

now lints on

let mut x = [1,2,3].into_iter();
loop {
   let Some(x) = x.next() else { break };
   dbg!(x);
}

changelog: [`while_let_loop`]: extend to lint on `let else`

[rustbot]

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[samueltardieu]

This should be auto-fixable, right?

[bend-n]

in theory, yeah?

[dswij]

Can we also include some test cases where the else block has side effects?

e.g.

    loop {
        //~^ while_let_loop
        let Some(_x) = y else {
            side_effect();
            break 
        };
    }

[dswij]

Should be auto-fixable. Let's do it in a separate PR. I created an issue for this #15702.

@bend-n would you want to help with this?