Skip to content

fix(bad_bit_mask): don't lint on #[cfg]-d consts #15665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(bad_bit_mask): don't lint on #[cfg]-d consts #15665

wants to merge 3 commits into from

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Sep 12, 2025

Fixes #14167

changelog: [bad_bit_mask]: don't lint on #[cfg]-d consts

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 12, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ada4a
clean-up and add comments
687195c 
RE: comments: I quickly got lost in all the `op`s and `left`s and
`right`s, so I wrote down them down to help me. I imagine they could be
helpful to the next person that looks at this
@ada4a
make the docs less condescending
1c9c249
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2025 •
edited
Loading

Lintcheck changes for 1d0027e

Lint Added Removed Changed
clippy::arithmetic_side_effects 3 0 0
clippy::cast_possible_truncation 1 0 0

This comment will be updated if you push new changes

@ada4a ada4a force-pushed the bit_mask branch 2 times, most recently from 5f276e9 to 8ffc8b6 Compare September 12, 2025 13:21
@ada4a
Copy link
Contributor Author

ada4a commented Sep 13, 2025

The added lint on https://docs.rs/clap_builder/4.5.9/src/clap_builder/output/help_template.rs.html#608 is a bit unfortunate, since TAB_WIDTH isn't really cfg-dependent, rather it's gated by the same feature that the place that uses it. I wonder if there is any way to find out whether an item is actually defined multiple times under different #[cfg] gates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@y21 y21

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bad_bit_mask is misguided and the documentation is misleading & unnecessarily combative
3 participants
@ada4a @rustbot @y21