Inline format-args automata #1286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
requested changes
Aug 24, 2025
regex-automata/src/dfa/dense.rs
Outdated
| @@ -2824,8 +2824,7 @@ impl OwnedDFA { | |||
| } | |||
| assert!( | |||
| !matches.contains_key(&start_id), | |||
| "{:?} is both a start and a match state, which is not allowed", | |||
| start_id, | |||
| "{start_id:?} is both a start and a match state, which is not allowed", | |||
There was a problem hiding this comment.
This line exceeds 79 columns. Please follow the convention of surrounding code.
I'm not going to go through and look for every other instance of this. Please fix all of them though. If this is too much tedious work, I'm fine closing this PR.
nyurik
force-pushed
the
inline-fmt-arg2
branch
2 times, most recently
from
8d772eb to
14a510e
Compare
This makes the code a bit easier to read and smaller. Some of it was done with this command, and later fixed by hand: ``` cargo clippy --workspace --allow-dirty --fix --benches --tests --bins -- -A clippy::all -W clippy::uninlined_format_args ```
nyurik
force-pushed
the
inline-fmt-arg2
branch
from
14a510e to
6af0d08
Compare
|
Fixed. Do note that there are quiet a few cases of |
|
I'm aware. It's not a hard rule. Many (not all) of those cases are rustfmt failures, hyperlinks or are otherwise long lines that are difficult to break. While there are many occurrences, they are still the exception, not the norm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code a bit easier to read and smaller.
Some of it was done with this command, and later fixed by hand: