-
Notifications
You must be signed in to change notification settings - Fork 236
WIP (do not merge): Support newer python and remove ugly dependencies #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes update Python version constraints, adjust dependencies by replacing and upgrading specific packages, and add a comment explaining the version pinning rationale in the project configuration file. No source code or public API declarations were modified. Changes
Sequence Diagram(s)No sequence diagram is generated as the changes are limited to configuration and dependency management. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
55-55
: Keep the caret pin but add a comment for clarity
^6.0
already means<7.0
; consider mirroring the Python comment for future maintainers:-pyinstaller = "^6.0" +pyinstaller = "^6.0" # 6.x is the first branch to (eventually) support Python ≥3.12
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lock
is excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
(2 hunks)
🔇 Additional comments (2)
pyproject.toml (2)
26-26
: PyInstaller Compatibility with Python 3.13 Confirmed✅ The PyInstaller package on PyPI specifies
• requires_python = “<3.14,>=3.8”
• includes the classifier “Programming Language :: Python :: 3.13”No changes required—Python 3.13 is officially supported.
30-30
: Import path verification passed for prometheus_api_client (0.6.0)
Installedprometheus-api-client-optional-matplotlib==0.6.0
and confirmed thatimport prometheus_api_client as pac print(pac.__version__) # → 0.6.0succeeds, ensuring all existing
import prometheus_api_client
statements remain valid.
Removes dependencies on matplotlib and PIL which cause all sorts of problems (see #436) by using my own fork of prometheus-api-client that doesn't have the problematic dependencies. This solves all sorts of problems and lets us update python versions etc.
This doesn't work yet because it needs an upgraded prometrix version to fully fix (which also replaces the dependency).
You can see this by running
poetry show --tree