Skip to content

Conversation

aantn
Copy link
Contributor

@aantn aantn commented Jul 13, 2025

Removes dependencies on matplotlib and PIL which cause all sorts of problems (see #436) by using my own fork of prometheus-api-client that doesn't have the problematic dependencies. This solves all sorts of problems and lets us update python versions etc.

This doesn't work yet because it needs an upgraded prometrix version to fully fix (which also replaces the dependency).
You can see this by running poetry show --tree

Copy link

coderabbitai bot commented Jul 13, 2025

Walkthrough

The changes update Python version constraints, adjust dependencies by replacing and upgrading specific packages, and add a comment explaining the version pinning rationale in the project configuration file. No source code or public API declarations were modified.

Changes

File Change Summary
pyproject.toml Updated Python version constraint, replaced "prometheus-api-client" with "prometheus-api-client-optional-matplotlib", upgraded "pyinstaller", and added explanatory comment.

Sequence Diagram(s)

No sequence diagram is generated as the changes are limited to configuration and dependency management.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aantn aantn changed the title Support newer python and remove ugly dependencies WIP (do not merge): Support newer python and remove ugly dependencies Jul 13, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pyproject.toml (1)

55-55: Keep the caret pin but add a comment for clarity

^6.0 already means <7.0; consider mirroring the Python comment for future maintainers:

-pyinstaller = "^6.0"
+pyinstaller = "^6.0"          # 6.x is the first branch to (eventually) support Python ≥3.12
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79680ee and 64e39c7.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (2 hunks)
🔇 Additional comments (2)
pyproject.toml (2)

26-26: PyInstaller Compatibility with Python 3.13 Confirmed

✅ The PyInstaller package on PyPI specifies
• requires_python = “<3.14,>=3.8”
• includes the classifier “Programming Language :: Python :: 3.13”

No changes required—Python 3.13 is officially supported.


30-30: Import path verification passed for prometheus_api_client (0.6.0)
Installed prometheus-api-client-optional-matplotlib==0.6.0 and confirmed that

import prometheus_api_client as pac
print(pac.__version__)  # → 0.6.0

succeeds, ensuring all existing import prometheus_api_client statements remain valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant