Check for rich formatting being enabled / disabled on a formatter #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case for a custom CSV formatter, and when I use it, I am running into an issue with line-wrapping causing the CSV to not render correctly. So it seems like when I set
rich_console=Falsewhen setting up a custom formatter, that should disable theconsole.printfunction. This fixes the issue I was having when writing the CSV.This PR enables using the value of
rich_consolein a formatter's decorator to specify whether to write a file directly or using Console to print, and converts thesettings.formatconditional to a more Pythonic approach.