Skip to content

Conversation

pelwell
Copy link
Contributor

@pelwell pelwell commented Sep 17, 2025

Enable support for the VEML6030 light sensor family.

See: #7048

Enable support for the VEML6030 light sensor family.

See: raspberrypi#7048

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@6by9
Copy link
Contributor

6by9 commented Sep 17, 2025

Was there meant to be an overlay to go alongside the defconfig addition?

@pelwell
Copy link
Contributor Author

pelwell commented Sep 17, 2025

You say overlay - does it need more than an entry in i2c-sensor-common.dtsi (which it doesn't yet have)?

Add a veml6030 parameter to the i2c-sensor overlay.

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@pelwell
Copy link
Contributor Author

pelwell commented Sep 17, 2025

Now with a veml6030-capable i2c-sensor overlay. I'm curious about the best default address, and whether configuring the interrupt line is preferred.

@6by9
Copy link
Contributor

6by9 commented Sep 17, 2025

You say overlay - does it need more than an entry in i2c-sensor-common.dtsi (which it doesn't yet have)?

No, that was all I meant.
The PR only updating the defconfigs appeared to be missing a bit.

Now with a veml6030-capable i2c-sensor overlay. I'm curious about the best default address, and whether configuring the interrupt line is preferred.

Seeing as the driver can work with or without interrupt, I'd go with leaving it disabled by default. Those who actually wire it up can enable it with an override. We have that with mcp23017 and probably a few others.

The options for address appear to be 0x48 (ADDR = high) or 0x10 (ADDR low). Your choice of 0x48 seems perfectly reasonable to me.

@pelwell
Copy link
Contributor Author

pelwell commented Sep 17, 2025

We have that with mcp23017 and probably a few others.

Unfortunately that's not how the i2c-sensor overlay is structured. Devices that support interrupts have it enabled permanently - the only option is to change the address. We have never said that int_pin has a default value, so we could demand the use of int_pin to enable them. Sadly it's not as simple as creating a dormant node that adds the necessary properties, but that would mean that interrupt-supporting devices need a second fragment (the targets are device-specific, and the interrupt type varies).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants