Skip to content

Conversation

Ikari-Shinji-re
Copy link
Member

Summary

The dynamic height feature of the widget hasn't worked reliably across all applications. This pull request aims to fix that:
#1210

I discussed the current solution with @nikaaru , and he pointed out that it adds unnecessary complexity. We've now replaced it with a simpler approach in this PR.

Interestingly, we had initially used a similar method during early development, but it caused various issues and introduced implicit dependencies on the host app. This PR revisits that approach for further testing.

It should be tested in different environments, including apps with nested layouts and the iframe version of the widget.

Fixes # (issue)

How did you test this change?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants