Skip to content

Conversation

RyukTheCoder
Copy link
Contributor

Summary

Ledger PR is migrated to use hub. All the changes are related to a typical provider migration except that derivationPath is added to parameters of connect action of Evm and Solana actions and also derivationPath is passed to it in useHubAdapter.

How did you test this change?

Tested by connecting to Ledger provider.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

@RyukTheCoder RyukTheCoder force-pushed the feat/rf-2499-migrate-ledger-to-use-hub branch from 428cf03 to 2a6dede Compare July 20, 2025 09:43
@RyukTheCoder RyukTheCoder force-pushed the feat/rf-2499-migrate-ledger-to-use-hub branch from 2a6dede to 9357d5c Compare July 20, 2025 12:08
@RyukTheCoder RyukTheCoder force-pushed the feat/rf-2499-migrate-ledger-to-use-hub branch 2 times, most recently from 6803483 to 50dc6fc Compare July 26, 2025 07:11
@RyukTheCoder RyukTheCoder requested a review from yeager-eren July 26, 2025 09:38
@RyukTheCoder RyukTheCoder force-pushed the feat/rf-2499-migrate-ledger-to-use-hub branch from 50dc6fc to ed8d04c Compare July 26, 2025 12:25
Copy link
Collaborator

@yeager-eren yeager-eren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants