-
Notifications
You must be signed in to change notification settings - Fork 35
feat: migrate ledger provider to use hub #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RyukTheCoder
wants to merge
1
commit into
next
Choose a base branch
from
feat/rf-2499-migrate-ledger-to-use-hub
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+407
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9678120
to
428cf03
Compare
yeager-eren
requested changes
Jul 14, 2025
428cf03
to
2a6dede
Compare
2a6dede
to
9357d5c
Compare
6803483
to
50dc6fc
Compare
50dc6fc
to
ed8d04c
Compare
yeager-eren
approved these changes
Jul 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. lgtm
3bbac1c
to
675a86c
Compare
675a86c
to
f84fa7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ledger PR is migrated to use hub. All the changes are related to a typical provider migration except that
derivationPath
is added to parameters of connect action of Evm and Solana actions and also derivationPath is passed to it inuseHubAdapter
.How did you test this change?
Tested by connecting to Ledger provider.
Checklist: