Structuring arguments in gen_candidates_torch #3019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Summary: Structuring the optimizer and stopping_criterion arguments in gen_candidates_torch. Fixes pytorch#2994. Differential Revision: D82839737
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3019 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 216 216
Lines 20482 20485 +3
=========================================
+ Hits 20482 20485 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hvarfner
force-pushed
the
export-D82839737
branch
from
5abf69e to
90e16b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Structuring the optimizer and stopping_criterion arguments in gen_candidates_torch.
Fixes #2994.
Differential Revision: D82839737