Skip to content

Conversation

aloctavodia
Copy link
Member

@aloctavodia aloctavodia commented Sep 6, 2025

In #7680 (comment) it was suggested that instead of deprecating find_constrained_prior, we should call PreliZ's maxent function.


📚 Documentation preview 📚: https://pymc--7905.org.readthedocs.build/en/7905/

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should revisit a pymc-based implementation later on, because it wouldn't be restricted to the offers /parametrizations in preliz and you could even have symbolic inputs / fixed parameters so you can apply it to intermediate variables, now that we have symbolic MinimizeOp in PyTensor.

@ricardoV94
Copy link
Member

Adding preliz to the env seems to have broken CI (or if not, something unrelated to this PR. We may be testing on a too old version of Python... (didn't check)

@aloctavodia
Copy link
Member Author

Makes sense. I think there is no unidimensional distribution/parameterization in pymc absent in preliz. But having symbolic inputs could be interesting. Maybe something worth to try is to replace variance with entropy. While entropy is more general and the correct thing to do. Maximizing the variance should work in most cases (or some other measure of spread).

@aloctavodia
Copy link
Member Author

Preliz use to have some functions that were removed and replaced for function already implemented in arviz-stats, which requieres python > 3.10

@ricardoV94
Copy link
Member

If python 3.10 is no longer supported by the numpy NEP we can drop it here as well, but maybe worth doing in a separate PR. CC'ing @maresb in case he wants to do it and you don't have the capacity @aloctavodia ?

@ricardoV94
Copy link
Member

ricardoV94 commented Sep 7, 2025

Sidenote, I guess we don't have mode in Beta in PyMC? Or did I miss the feature being introduced at some point?

@aloctavodia
Copy link
Member Author

I don't remember the exact date to drop 3.10, but it was in the first semester.
I also don't remember if the mode is available on PyMC, but that should not be a problem for this function to work, as the mode restraint is applied to a preliz distribution, and if the distribution does not have a mode, the user is notified.

@maresb
Copy link
Contributor

maresb commented Sep 8, 2025

I have no strong feelings. I am pretty low availability this month. I'll take care of the conda-forge updates for everything though. (Ping me if needed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants