-
Notifications
You must be signed in to change notification settings - Fork 2.1k
use preliz under the hood of find_constrained_prior
#7905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we should revisit a pymc-based implementation later on, because it wouldn't be restricted to the offers /parametrizations in preliz and you could even have symbolic inputs / fixed parameters so you can apply it to intermediate variables, now that we have symbolic MinimizeOp in PyTensor.
Adding preliz to the env seems to have broken CI (or if not, something unrelated to this PR. We may be testing on a too old version of Python... (didn't check) |
Makes sense. I think there is no unidimensional distribution/parameterization in pymc absent in preliz. But having symbolic inputs could be interesting. Maybe something worth to try is to replace variance with entropy. While entropy is more general and the correct thing to do. Maximizing the variance should work in most cases (or some other measure of spread). |
Preliz use to have some functions that were removed and replaced for function already implemented in arviz-stats, which requieres python > 3.10 |
If python 3.10 is no longer supported by the numpy NEP we can drop it here as well, but maybe worth doing in a separate PR. CC'ing @maresb in case he wants to do it and you don't have the capacity @aloctavodia ? |
Sidenote, I guess we don't have mode in Beta in PyMC? Or did I miss the feature being introduced at some point? |
I don't remember the exact date to drop 3.10, but it was in the first semester. |
I have no strong feelings. I am pretty low availability this month. I'll take care of the conda-forge updates for everything though. (Ping me if needed.) |
In #7680 (comment) it was suggested that instead of deprecating
find_constrained_prior
, we should call PreliZ's maxent function.📚 Documentation preview 📚: https://pymc--7905.org.readthedocs.build/en/7905/